Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles to specify what kind of cycle they are #247

Open
distributive opened this issue May 10, 2024 · 2 comments
Open

Cycles to specify what kind of cycle they are #247

distributive opened this issue May 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@distributive
Copy link
Contributor

distributive commented May 10, 2024

Some cycles are cycles (e.g. Borealis) whereas some cycles are just singular sets (e.g. Gateway, System Update). In the same way sets have a cardSetType it would be useful to add a cardCycleType.

Off the top of my head, I think cycles would just need a Cycle and Set type, but you could maybe extend it to include core, expansion, etc. to match the card set types.

@plural
Copy link
Contributor

plural commented May 11, 2024

They've always been treated as roughly the same. What types of values do you see this having and what will we do with it?

i'm not convinced a cycle that is a single set needs a different type, but things like draft, salvaged memories, or the magnum opus packs could do with some differentiator.

@plural
Copy link
Contributor

plural commented Jun 15, 2024

@distributive - what else do you want to use this for?

@plural plural added the enhancement New feature or request label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants