Skip to content

Commit 31d1381

Browse files
authored
Merge pull request #93 from NeuroML/development
Updates for NMLv2.3
2 parents df2d472 + 5801d66 commit 31d1381

File tree

7 files changed

+83
-96
lines changed

7 files changed

+83
-96
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
java: [ '8', '11', '16', '17' ]
20-
runs-on: [ubuntu-latest, macos-11, windows-2019 ]
19+
java: [ '8', '11', '16', '17', '19']
20+
runs-on: [ubuntu-latest, macos-latest, windows-2019 ]
2121

2222
name: Test on Java ${{ matrix.Java }} on ${{ matrix.runs-on }}
2323
steps:
@@ -68,10 +68,12 @@ jobs:
6868
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -cvode
6969
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -matlab
7070
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -dlems
71+
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -eden
7172
./jnml ../NeuroML2/LEMSexamples/regression-tests/LEMS_NML2_Ex5_DetCell_unformatted.xml -nogui
7273
./jnml ../NeuroML2/examples/NML2_SimpleMorphology.nml -svg
7374
ls -alt ../NeuroML2/examples
7475
ls -alt ../NeuroML2/LEMSexamples
76+
env
7577
7678
- name: Further tests (Win)
7779
if: ${{ matrix.runs-on == 'windows-2019' }}
@@ -87,5 +89,6 @@ jobs:
8789
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -cvode
8890
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -matlab
8991
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -dlems
92+
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -eden
9093
.\jnml.bat ..\NeuroML2\LEMSexamples\regression-tests\LEMS_NML2_Ex5_DetCell_unformatted.xml -nogui
9194
.\jnml.bat ..\NeuroML2\examples\NML2_SimpleMorphology.nml -svg

.travis.yml

Lines changed: 0 additions & 58 deletions
This file was deleted.

getNeuroML.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,8 @@ def main():
125125
or ("jNeuroML" in repo)
126126
)
127127

128-
if (repo in java_repos or repo in neuroml2_spec_repo) and runMvnInstall:
128+
if (repo in java_repos or repo in neuroml2_spec_repo) \
129+
and runMvnInstall:
129130
command = "mvn install"
130131
print("It's a Java repository, so installing using Maven...")
131132
info = execute_command_in_dir(command, local_dir)
@@ -162,7 +163,8 @@ def execute_command_in_dir(command, directory, exit_on_fail=True):
162163
% (command, directory, os.path.abspath(directory))
163164
)
164165

165-
p = subprocess.Popen(command, cwd=directory, shell=True, stdout=subprocess.PIPE)
166+
p = subprocess.Popen(command, cwd=directory, shell=True,
167+
stdout=subprocess.PIPE)
166168
return_str = p.communicate()
167169

168170
if p.returncode != 0:

jnml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# Type java -X for more info
66
export JNML_MAX_MEMORY=400M
77

8-
export JNML_VERSION=0.11.1
8+
export JNML_VERSION=0.12.4
99

1010

1111
export CLASSPATH=.:./target/jNeuroML-$JNML_VERSION-jar-with-dependencies.jar:$JNML_HOME/target/jNeuroML-$JNML_VERSION-jar-with-dependencies.jar

jnml.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@echo off
22

3-
set JNML_VERSION=0.11.1
3+
set JNML_VERSION=0.12.4
44

55
set CLASSPATH=target\jNeuroML-%JNML_VERSION%-jar-with-dependencies.jar;%JNML_HOME%\jNeuroML-%JNML_VERSION%-jar-with-dependencies.jar
66

pom.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>org.neuroml</groupId>
66
<artifactId>jNeuroML</artifactId>
7-
<version>0.11.1</version>
7+
<version>0.12.4</version>
88
<packaging>jar</packaging>
99

1010
<name>jNeuroML</name>
@@ -24,26 +24,24 @@
2424
<dependency>
2525
<groupId>org.neuroml1.model</groupId>
2626
<artifactId>org.neuroml1.model</artifactId>
27-
<version>1.8.1</version>
27+
<version>1.9.1</version>
2828
</dependency>
2929
<dependency>
3030
<groupId>org.neuroml.import</groupId>
3131
<artifactId>org.neuroml.import</artifactId>
32-
<version>1.8.1</version>
32+
<version>1.9.1</version>
3333
</dependency>
3434

3535
<!-- Dependencies to force use of log4j 2.17.1 -->
3636
<dependency>
3737
<groupId>org.apache.logging.log4j</groupId>
3838
<artifactId>log4j-1.2-api</artifactId>
3939
<version>2.17.1</version>
40-
<scope>test</scope>
4140
</dependency>
4241
<dependency>
4342
<groupId>org.apache.logging.log4j</groupId>
4443
<artifactId>log4j-slf4j-impl</artifactId>
4544
<version>2.17.1</version>
46-
<scope>test</scope>
4745
</dependency>
4846

4947

@@ -61,7 +59,7 @@
6159
&lt;br /&gt;
6260
&lt;br /&gt;
6361
</top>
64-
<bottom>Copyright NeuroML Contributors 2021</bottom>
62+
<bottom>Copyright NeuroML Contributors 2023</bottom>
6563
</configuration>
6664
</plugin>
6765
<plugin>

0 commit comments

Comments
 (0)