Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FOOOF section on 01r_n170_viz #179

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

GiovanniChiarion
Copy link

@GiovanniChiarion GiovanniChiarion commented Apr 19, 2022

I added a new section of PSD parametrization using FOOOF algorithm proposed by Thomas Donoghue @TomDonoghue
I hope it could be appreciated.

@JohnGriffiths
Copy link
Collaborator

Ciao Giovanni.

Thanks for this contribution.

This is a great idea.

A few requests before we can merge what you've done here:

  1. It would be better if the FOOOF analysis is done separately a stand-alone example, so there is sufficient space to explain what it's doing without over-complicating the existing examples.

  2. In that new example script, take the time to explain in the file comments what it is that you are plotting, and what they mean and your general interpretation of what you're observing.

Note, I think you need to add some plt.show() lines for all of the figures to appear when running the script on windows.

Best,

j

@GiovanniChiarion
Copy link
Author

Sorry for the late reponse, I've done as you suggested and created a new example file (03r_n170_fooof.py) and reverted changes to the first example. I hope to haven't done too much messes with git.
Let me know if everything is ok :)

@JohnGriffiths JohnGriffiths self-assigned this Nov 16, 2023
@oreHGA oreHGA changed the base branch from master to develop November 16, 2023 15:33
@alexfigtree
Copy link
Member

@JohnGriffiths What's the status on this, does it still need to be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants