Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units should be consistent across neural mass blocks #284

Open
agchesebro opened this issue Sep 18, 2023 · 2 comments
Open

Units should be consistent across neural mass blocks #284

agchesebro opened this issue Sep 18, 2023 · 2 comments

Comments

@agchesebro
Copy link
Member

We should have a discussion about this at some point - each block is internally consistent but some are on different time scales (e.g., Jansen-Rit has default parameters in seconds vs Larter-Breakspear in milliseconds). Not a huge issue now because all models are kept separate, but if you wanted to link blocks of different kinds it'll become a thorny problem.

@harisorgn
Copy link
Member

but if you wanted to link blocks of different kinds it'll become a thorny problem.

Also a serious issue when connecting to sources that emulate some sort of trial with image presentations and pauses in milliseconds for example, and when doing reinforcement learning, updating weights every N milliseconds etc.

This package provides a nice interface for units :
https://painterqubits.github.io/Unitful.jl/stable/

@agchesebro
Copy link
Member Author

This was actually mostly addressed in PR #295. Leaving this open for units, but I forgot to comment on this issue at the time. All neural masses are now in milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants