Update handling of colnames #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 93.20% 92.88% -0.33%
==========================================
Files 62 62
Lines 4328 4441 +113
Branches 268 272 +4
==========================================
+ Hits 4034 4125 +91
- Misses 284 306 +22
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the handling of the colNames to:
colNamesto the end by addingDynamicTable.finalizeakin toElectrodeTable.finalize. This allows for columns to be added to theDynamicTablecolNamesfromDynamicTableconstructor toinitialize#129 This is also addressed by the former as we now accumulatecolNamesas columns are being added, rather than requiring thecolNamesto be set when creating the table.StatusforDynamicTablefunctions that perform write operations (e.g,.initialize,finalize,add_columnetc.) as well as relevant other classes, e.g.,Data,VectorDataetc.