Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor l-curve comments #46

Open
asiaszmek opened this issue Jun 14, 2018 · 3 comments
Open

minor l-curve comments #46

asiaszmek opened this issue Jun 14, 2018 · 3 comments

Comments

@asiaszmek
Copy link
Collaborator

  1. estimate='CSD'is a parameter of L_curve, it is not used anywhere.
  2. L_curve does not return anything despite the statement in the docstrings.
  3. decimal=3 in prints, skcsd uses source widths of the order of tens of microns.
  4. Rs is converted to an array, lambdas isn't, it would be quite useful, if it was.
@ccluri
Copy link
Collaborator

ccluri commented Nov 11, 2018

Is there any analysis of L-Curve predictions with time?
An example of this would be nice.

@ccluri
Copy link
Collaborator

ccluri commented Nov 27, 2018

@asiaszmek are these addressed in #70 ? Can we close this?

@ccluri
Copy link
Collaborator

ccluri commented Apr 7, 2019

Bump @asiaszmek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants