From d9eb9daa12bade6c725dfd2d5f02eb8223eee5ac Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 13:56:20 -0500 Subject: [PATCH 1/6] Removing default probes --- charts/daemonset-app/values.yaml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/charts/daemonset-app/values.yaml b/charts/daemonset-app/values.yaml index 7cb60783..3abd3052 100644 --- a/charts/daemonset-app/values.yaml +++ b/charts/daemonset-app/values.yaml @@ -98,23 +98,17 @@ volumes: [] # -- A PodSpec container "startupProbe" configuration object. Note that this # startupProbe will be applied to the proxySidecar container instead if that # is enabled. -startupProbe: +startupProbe: {} # -- A PodSpec container "livenessProbe" configuration object. Note that this # livenessProbe will be applied to the proxySidecar container instead if that # is enabled. -livenessProbe: - httpGet: - path: / - port: http +livenessProbe: {} # -- A PodSpec container "readinessProbe" configuration object. Note that this # readinessProbe will be applied to the proxySidecar container instead if that # is enabled. -readinessProbe: - httpGet: - path: / - port: http +readinessProbe: {} # -- A list of Port objects that are exposed by the service. These ports are # applied to the main container, or the proxySidecar container (if enabled). From a0e522a33f7b65851ee0bb21f623e2bfc96c0223 Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 14:02:14 -0500 Subject: [PATCH 2/6] Update version --- charts/daemonset-app/Chart.yaml | 2 +- charts/daemonset-app/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/daemonset-app/Chart.yaml b/charts/daemonset-app/Chart.yaml index a9fd7fe0..510296fc 100644 --- a/charts/daemonset-app/Chart.yaml +++ b/charts/daemonset-app/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: daemonset-app description: Default DaemonSet Helm Chart type: application -version: 0.13.0 +version: 0.13.1 appVersion: latest maintainers: - name: diranged diff --git a/charts/daemonset-app/README.md b/charts/daemonset-app/README.md index 7957d3dd..93f6fc5f 100644 --- a/charts/daemonset-app/README.md +++ b/charts/daemonset-app/README.md @@ -2,7 +2,7 @@ Default DaemonSet Helm Chart -![Version: 0.13.0](https://img.shields.io/badge/Version-0.13.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) +![Version: 0.13.1](https://img.shields.io/badge/Version-0.13.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) [statefulsets]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/ [hpa]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/ From 13b9c8e1c6c4a291e1ceb15f0b3db5c6adb3b0de Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 14:07:05 -0500 Subject: [PATCH 3/6] Change to null --- charts/daemonset-app/values.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/daemonset-app/values.yaml b/charts/daemonset-app/values.yaml index 3abd3052..c07ff3ae 100644 --- a/charts/daemonset-app/values.yaml +++ b/charts/daemonset-app/values.yaml @@ -98,17 +98,17 @@ volumes: [] # -- A PodSpec container "startupProbe" configuration object. Note that this # startupProbe will be applied to the proxySidecar container instead if that # is enabled. -startupProbe: {} +startupProbe: null # -- A PodSpec container "livenessProbe" configuration object. Note that this # livenessProbe will be applied to the proxySidecar container instead if that # is enabled. -livenessProbe: {} +livenessProbe: null # -- A PodSpec container "readinessProbe" configuration object. Note that this # readinessProbe will be applied to the proxySidecar container instead if that # is enabled. -readinessProbe: {} +readinessProbe: null # -- A list of Port objects that are exposed by the service. These ports are # applied to the main container, or the proxySidecar container (if enabled). From d6a39a0afaf6fe4a5e3cccd637ed1a9883ae52c3 Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 14:16:46 -0500 Subject: [PATCH 4/6] Update version and docs --- charts/daemonset-app/Chart.yaml | 2 +- charts/daemonset-app/README.md | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/charts/daemonset-app/Chart.yaml b/charts/daemonset-app/Chart.yaml index 510296fc..bd027d61 100644 --- a/charts/daemonset-app/Chart.yaml +++ b/charts/daemonset-app/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: daemonset-app description: Default DaemonSet Helm Chart type: application -version: 0.13.1 +version: 0.14.0 appVersion: latest maintainers: - name: diranged diff --git a/charts/daemonset-app/README.md b/charts/daemonset-app/README.md index 93f6fc5f..9b6dd4b5 100644 --- a/charts/daemonset-app/README.md +++ b/charts/daemonset-app/README.md @@ -2,7 +2,7 @@ Default DaemonSet Helm Chart -![Version: 0.13.1](https://img.shields.io/badge/Version-0.13.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) +![Version: 0.14.0](https://img.shields.io/badge/Version-0.13.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) [statefulsets]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/ [hpa]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/ @@ -13,6 +13,12 @@ ServiceAccounts, Services, etc. ## Upgrade Notes +### 0.13.x -> 0.14.x + +**BREAKING: Bugfix default probes got removed** + +Removing default readiness and liveness probes due to conflicts with custom defined ones. + ### 0.10.x -> 0.11.x **NEW: Optional sidecar and init containers** From c3a1f3c5bd192a84b092a478746410fd687ee1a4 Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 14:17:52 -0500 Subject: [PATCH 5/6] Update version and docs --- charts/daemonset-app/README.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/charts/daemonset-app/README.md b/charts/daemonset-app/README.md index 9b6dd4b5..6e162fb9 100644 --- a/charts/daemonset-app/README.md +++ b/charts/daemonset-app/README.md @@ -2,7 +2,7 @@ Default DaemonSet Helm Chart -![Version: 0.14.0](https://img.shields.io/badge/Version-0.13.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) +![Version: 0.14.0](https://img.shields.io/badge/Version-0.14.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square) [statefulsets]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/ [hpa]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/ @@ -13,12 +13,6 @@ ServiceAccounts, Services, etc. ## Upgrade Notes -### 0.13.x -> 0.14.x - -**BREAKING: Bugfix default probes got removed** - -Removing default readiness and liveness probes due to conflicts with custom defined ones. - ### 0.10.x -> 0.11.x **NEW: Optional sidecar and init containers** From 160d10ea9a10128fd96933145da99165c5ad42dc Mon Sep 17 00:00:00 2001 From: Shalom Cohen Date: Tue, 21 Nov 2023 14:21:35 -0500 Subject: [PATCH 6/6] Update version and docs --- charts/daemonset-app/README.md | 6 ++++++ charts/daemonset-app/README.md.gotmpl | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/charts/daemonset-app/README.md b/charts/daemonset-app/README.md index 6e162fb9..0da55b5b 100644 --- a/charts/daemonset-app/README.md +++ b/charts/daemonset-app/README.md @@ -13,6 +13,12 @@ ServiceAccounts, Services, etc. ## Upgrade Notes +### 0.13.0 -> 0.14.x + +**BREAKING: Bugfix removing the default readiness and liveness probes ** + +Removing the default readiness and liveness probes due to conflicts with custom defined ones. + ### 0.10.x -> 0.11.x **NEW: Optional sidecar and init containers** diff --git a/charts/daemonset-app/README.md.gotmpl b/charts/daemonset-app/README.md.gotmpl index 033ef959..845ead71 100644 --- a/charts/daemonset-app/README.md.gotmpl +++ b/charts/daemonset-app/README.md.gotmpl @@ -12,6 +12,12 @@ ServiceAccounts, Services, etc. ## Upgrade Notes +### 0.13.0 -> 0.14.x + +**BREAKING: Bugfix removing the default readiness and liveness probes ** + +Removing the default readiness and liveness probes due to conflicts with custom defined ones. + ### 0.10.x -> 0.11.x **NEW: Optional sidecar and init containers**