From 31060f9cae879ca06c2c39d49535aa0a8af72370 Mon Sep 17 00:00:00 2001 From: Alex Kennedy Date: Tue, 21 Jan 2025 14:58:24 -0800 Subject: [PATCH] fix: Remove private GHA mechanisms (#545) --- .github/nextdoor.yml | 1 - .github/workflows/main-release.yaml | 12 ++++-------- .github/workflows/release_drafter.yml | 20 ++++++++++++++++---- .github/workflows/test.yaml | 12 ++++-------- 4 files changed, 24 insertions(+), 21 deletions(-) delete mode 100644 .github/nextdoor.yml diff --git a/.github/nextdoor.yml b/.github/nextdoor.yml deleted file mode 100644 index bcc0e562..00000000 --- a/.github/nextdoor.yml +++ /dev/null @@ -1 +0,0 @@ -slackChannel: "#kingpin" diff --git a/.github/workflows/main-release.yaml b/.github/workflows/main-release.yaml index cbfe860f..a7f77095 100644 --- a/.github/workflows/main-release.yaml +++ b/.github/workflows/main-release.yaml @@ -12,15 +12,11 @@ jobs: uses: actions/setup-python@v5 with: python-version: '3.x' - - name: Run make venv - run: make venv + - run: make venv shell: bash - - name: Run make lint - run: make lint + - run: make lint shell: bash - - name: Run make test - run: make test + - run: make test shell: bash - - name: Run make build - run: make build + - run: make build shell: bash diff --git a/.github/workflows/release_drafter.yml b/.github/workflows/release_drafter.yml index 38dcb91b..1a3d68fb 100644 --- a/.github/workflows/release_drafter.yml +++ b/.github/workflows/release_drafter.yml @@ -1,9 +1,21 @@ -name: release-drafter +name: Release Drafter on: push: branches: - main + pull_request: + types: [opened, reopened, synchronize] +permissions: + contents: read jobs: - drafter: - uses: Nextdoor/.github/.github/workflows/release-drafter.yml@main - secrets: inherit + update_release_draft: + permissions: + contents: write + pull-requests: read + runs-on: ubuntu-latest + steps: + - uses: release-drafter/release-drafter@v6 + with: + disable-autolabeler: true + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 0a203e56..4d09bd93 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -10,15 +10,11 @@ jobs: uses: actions/setup-python@v5 with: python-version: '3.x' - - name: Run make venv - run: make venv + - run: make venv shell: bash - - name: Run make lint - run: make lint + - run: make lint shell: bash - - name: Run make test - run: make test + - run: make test shell: bash - - name: Run make build - run: make build + - run: make build shell: bash