From 2789e0e56249174110c0cee7bfc9e674b47891a0 Mon Sep 17 00:00:00 2001 From: Sewer56 Date: Thu, 19 Sep 2024 15:35:59 +0100 Subject: [PATCH] Added: Extra note to the PR --- .../RunGarbageCollector.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/NexusMods.App.GarbageCollection.DataModel/RunGarbageCollector.cs b/src/NexusMods.App.GarbageCollection.DataModel/RunGarbageCollector.cs index baae07196..ad20f4fad 100644 --- a/src/NexusMods.App.GarbageCollection.DataModel/RunGarbageCollector.cs +++ b/src/NexusMods.App.GarbageCollection.DataModel/RunGarbageCollector.cs @@ -42,6 +42,10 @@ public static void Do(Span archiveLocations, IFileStore store, // prevent this from happening if possible. // // This is why we release `store.Lock()` early. + + // NOTE: In theory UpdateNxFileStore can call GC back again. This is unlikely to happen + // however for the time being; because we only run GC when deleting a library item + // or loadout. var updater = new NxFileStoreUpdater(connection); foreach (var entry in toUpdateInDataStore) {