Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how we mark Entities as deleted in database #1508

Closed
Tracked by #1554
Al12rs opened this issue May 30, 2024 · 1 comment
Closed
Tracked by #1554

Standardize how we mark Entities as deleted in database #1508

Al12rs opened this issue May 30, 2024 · 1 comment
Assignees
Labels
Epic: Tech-debt Technical debt, this needs solving in the long-term Tech: data-store This is related to the Data Store.

Comments

@Al12rs
Copy link
Contributor

Al12rs commented May 30, 2024

Improvement

Currently

In MnemonicDB you can't really remove data, so deletes are expressed by either retracting datom values or by adding some kind of marker.
We have different entities like Loadouts, Mods, File entries, Download Data, etc and we are using different approaches for each entity type.

We want

A standardized way to mark entities as deleted.
Ideally this would be handled on the DB API side. We wouldn't be getting deleted entities from queries.
We would likely still need a way to access those, but not from the main APIs.

@Al12rs Al12rs added Tech: data-store This is related to the Data Store. Epic: Tech-debt Technical debt, this needs solving in the long-term labels May 30, 2024
@Al12rs Al12rs added this to MVP May 30, 2024
@Al12rs Al12rs moved this to In Progress in MVP Jun 6, 2024
@halgari halgari moved this from In Progress to Review in MVP Jun 25, 2024
@halgari
Copy link
Collaborator

halgari commented Jul 2, 2024

Done as part of #1626

@halgari halgari closed this as completed Jul 2, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in MVP Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Tech-debt Technical debt, this needs solving in the long-term Tech: data-store This is related to the Data Store.
Projects
Archived in project
Development

No branches or pull requests

2 participants