-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepency when installing a collection in the app vs Vortex #2193
Comments
The discrepancy seems to be related to #2194 |
Need to use Vortex logic for "Prefer exact" Vortex also adds some files that dont appear in the loadout. East Scarp mod gets missed out and the file is not included. |
Did we say that this had been resolved? Or did it need more investigation? |
I can go over the various things to make sure when I have some time this sprint |
I investigated this, installing the collection both in Vortex and the app and found 3 main differences:
|
I think |
Why would it be excluded in that case? Does it trigger the nested mod installer? |
I'm not sure, the |
I did debug it and it did in fact add the file to the mod and applying deployed the file as expected. I don't know why it worked while debugging single mod install and not during the collection install |
Is there further work to do on this or can it be considered complete? |
I could try looking into the Credits.xlsx file discrepancy more, the rest is either resolved or out of scope (missing file conflict sorting) |
After some debugging this seems to be the case. We call This means that any file detected to be an archive will be extracted and the archive itself not backed up. This can be problematic for any mod format that contains files that can be recognized as archives from our code. |
This will likely pop up again for BSA/BA2 files. We should make a new issue just for that. |
For this ticket the remaining discrepancy is for the Config files, which is caused by the fact that the Collection contains a mod with a bunch of config file overrides, that needs to win conflicts with the other mods.
|
I think the best way to fix this for now, and perhaps forever, is to have a specific list of archives we descend into. We should do this analysis for .zip, .rar, .7z, etc but not for |
Created a ticket from the Collection feature list to cover the Config discrepancy part: @LukeNexusMods closing this issue in favour of |
Bug Report
Summary
I have installed a variant of the most popular Stardew Valley collection into the app with both Vortex and the app, then compared the resulting list of files in the game folder.
In this test, I've excluded the
_folder_managed_by_vortex
andvortex.deployment.json
files as they aren't relevant to the end result.Observations
StardewValley.exe
file (did we agree to stop doing that?) soStardewModdingAPI.exe
is absent.Mods\East Scarp (1.6)\[CP] East Scarp\NPCs
is missing, including all contents. This is concerning as this is a sizable chunk of the mod.Mods\Portraits for Vendors\[CP] Portraits for Vendors\assets\Credits.xlsx
is missing. Are we being too opinionated about file extensions? Removing this file won't break the modding setup, but we also have no reason not to install it.Steps to reproduce
dir /s /b /o:gn > App_Files.txt
incmd
Note: I did not hash the files, you can do this for a more detailed comparison.
What is the expected behaviour?
The install of the collection produces the same files in both Vortex and the app.
Other information
nexusmods.app.main.current.log
nexusmods.app.slim.current.log
App_Files.txt
Vortex_Files.txt
The text was updated successfully, but these errors were encountered: