Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unexpected logging messages from py-sdk #169

Open
onikonychev opened this issue Nov 8, 2022 · 1 comment
Open

bug: unexpected logging messages from py-sdk #169

onikonychev opened this issue Nov 8, 2022 · 1 comment
Labels
type: bug Something isn't working

Comments

@onikonychev
Copy link
Collaborator

Here and there in liquidator and heart-monitor some unexpected py-sdk messages are appearinng:

12:06:41|DEBUG|_handle_txs| Failed parsing events log: failed to execute message; message index: 0: 0unibi is smaller than 100000000unibi: insufficient funds. Expecting value: line 1 column 1 (char 0)

Need to make sdk and app logging consistent and have an ability to turn off DEBUG if it's not intentionally on.

@Unique-Divine
Copy link
Member

Unique-Divine commented Dec 9, 2022

What I'd do for this behavior is use argparse from the standard library and add a flag for --log or --loglevel that adjusts the logging.basicConfig. That way, you can customize whether you want to see the DEBUG, INFO, and WARNING statements on different runs.

Another option could be that we add an argument, log_level to the constructor for the nibiru.Sdk object. Then, you'd be able to adjust it at the program level when you initialize the Sdk.

I'm in favor of implementing both of these, tbh

@Unique-Divine Unique-Divine added the type: bug Something isn't working label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants