Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controllers aka node specs] Differences in how "defaultConfig" and "defaultValue" is used #639

Open
jgresham opened this issue Aug 1, 2024 · 0 comments

Comments

@jgresham
Copy link
Member

jgresham commented Aug 1, 2024

Problem details

When setting execution.input.defaultConfig it forces those values to be used on the run command anytime before the user has "saved" from the node settings modal. After the user has saved from the node settings modal, ALL of the configs' defaultValues are included in the run command.

This shouldn't cause any issues, but it does mean that there are a bunch of additional default value cli input after the users saves the settings (doesn't even have to make a change to any of them). It also means that we have to explicitly include default config that should be used on every run command in 2 places execution.input.defaultConfig and as a defaultValue under the specific config.

@jgresham jgresham changed the title Differences in how "defaultConfig" and "defaultValue" is used [controllers aka node specs] Differences in how "defaultConfig" and "defaultValue" is used Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant