From e6210005425bd991ce1e5bf0ecd98c37c190a3d3 Mon Sep 17 00:00:00 2001 From: NickAc <32451103+NickAcPT@users.noreply.github.com> Date: Wed, 28 Aug 2024 00:26:04 +0100 Subject: [PATCH] Make sure we actually skip emissives in Bbmodel generation Turns out that EarsFeatures is Copy and I was editing a copy of it instead of the original, whoops! --- .../src/generator.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/nmsr-rendering-blockbench-model-generator-experiment/src/generator.rs b/utils/nmsr-rendering-blockbench-model-generator-experiment/src/generator.rs index 6d7052f..e575721 100644 --- a/utils/nmsr-rendering-blockbench-model-generator-experiment/src/generator.rs +++ b/utils/nmsr-rendering-blockbench-model-generator-experiment/src/generator.rs @@ -141,7 +141,7 @@ impl ModelGenerationProject { } } - let features = EarsParser::parse(&texture)?; + let mut features = EarsParser::parse(&texture)?; if let (Some(features), Ok(None)) = (features, alfalfa) { let wings_enabled = features.wing.is_some(); @@ -164,7 +164,7 @@ impl ModelGenerationProject { } } - if let Some(mut features) = features { + if let Some(ref mut features) = features { // Harcode emissives to false - I believe blockbench supports emissive textures, // but Ears skins' emissives aren't separate textures, and instead are based off of specific colors. features.emissive = false;