You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
th3w1zard1
changed the title
Patcher - Missing support for TSLPatcher's [HACKList]
Patcher - Testing/support needed for TSLPatcher's [HACKList]Jan 31, 2024
While trying to write up a full spec for the changes.ini format to aid my mobile port (after disappearing off the face of the earth... again... oops 😅), I found this post on the LucasForums archive where stoffe explains what TSLPatcher expects of hackfiles, which is subtly different from the current implementation.
TL;DR:
The key is a decimal offset. (HoloPatcher defaults to the same unless it has a hex prefix, so no compatibility issues here.)
The value is a signed 32-bit decimal integer. (HoloPatcher expects unsigned and defaults to 16-bit, though I suspect it should parse negatives correctly anyway since it just uses int().)
If the target file has a .ncs extension it is written with big-endian ordering, otherwise it is written with little-endian. (HoloPatcher always does big-endian and regards it as an NCS-only feature... which in practice it probably is.)
If the target file already exists and ReplaceFile is false, it will be skipped because offsets might not be reliable. (HoloPatcher only enables skip_if_not_replace for InstallList and CompileList currently.)
Given the extremely limited number of mods using the feature I don't know if any of these differences would've ever reared their heads, though, and I have no idea if fixing them now would break anything that relies on HoloPatcher's current behavior.
(Apologies if this was already discussed in the Discord conversations, I can't see what server the link points to.)
See the conversation around here for details.
The text was updated successfully, but these errors were encountered: