Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module conflict causing overwrite #3

Open
unsatisfying opened this issue Apr 11, 2023 · 3 comments
Open

Module conflict causing overwrite #3

unsatisfying opened this issue Apr 11, 2023 · 3 comments

Comments

@unsatisfying
Copy link

I try to install your project using Pip. I found that your project will depend on the project "PyKotor==1.5.4". After installing the dependencies, some of the files in your project will overwrite some of the files in PyKotor. This includes mainly the modules in the "pykotor" root directory and the "venv" root directory.

@NickHugi
Copy link
Owner

NickHugi commented Jul 11, 2023

I assume you meant that you tried to install PyKotorGL? All of PyKotorGL's modules are under /pykotor/gl/ so there shouldnt be any actual overlap occuring.

@unsatisfying
Copy link
Author

unsatisfying commented Jul 22, 2023

In fact, I think it would be a packaging issue. You uploaded the PyKotorGL-1.2.1-py3-none-any.whl file includes files like pykotor/gl/scene.py, and venv/ .etc. PyKotorGL also depends on PyKotor, and PyKotor's packaging file
PyKotor-1.6.2-py3-none-any.whl also includes pykotor/gl/scene.py and other venv/ files. Therefore, in the process of installing PyKotorGL, pip will install the dependency packages first (i.e. [email protected]), then install [email protected]. During this process, it is the conflicting modules are overwritten. It can be noticed that the contents of the files in these two packages are not the same, so there might be a functionality problem.

@th3w1zard1
Copy link
Collaborator

th3w1zard1 commented Nov 5, 2023

@NickHugi Might need to take a look at this again after that large merge of #18 I completely forgot to check the pip package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants