Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measures param for grid search and cross_validate should support callables #166

Open
NicolasHug opened this issue Apr 6, 2018 · 0 comments

Comments

@NicolasHug
Copy link
Owner

For now only strings are accepted as the measures parameter in GridSearchCV, RandomizedSearchCV, and cross_validate. It's thus impossible to use those with measures that take specific parameters as input (e.g. #156 ), or to use custom measures.

We should then accept callables in addition to strings.

Each callable should only take the predictions parameter. In order to handle measures with mulptile parameters, we could implement a make_measure helper (much like sklearn make_scorer) which would simply perform some partial application on the parameters, and set a greater_is_better parameter (this would clean a bit the current code).

Any other option is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant