Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setuptools_scm instead of hard-coding version in const.py #33

Open
bigjools opened this issue Feb 28, 2024 · 0 comments
Open

Use setuptools_scm instead of hard-coding version in const.py #33

bigjools opened this issue Feb 28, 2024 · 0 comments

Comments

@bigjools
Copy link
Collaborator

It's impossible to do a release from the gitub releases page as the build version is hard-coded in the spinach/const.py file, which is picked up by setup.py.

We can use setuptools_scm instead which will get the version from the git tag.

While we're at it, convert to a modern pyproject.toml and use Hatch to build.
0xDEC0DE pushed a commit to 0xDEC0DE/spinach that referenced this issue Feb 28, 2024
@nisimond
Modernize Python tooling
4f57896 
Move all configs into `pyproject.toml`, switch test/packaging to
use Hatch, and do all the linting with Ruff.

Fix issues that Ruff turned up, and annotate/ignore the pieces that
it got wrong.

Fixes: Issue NicolasLM#33
@0xDEC0DE 0xDEC0DE mentioned this issue Feb 28, 2024
Open
0xDEC0DE pushed a commit to 0xDEC0DE/spinach that referenced this issue Feb 28, 2024
@nisimond
Modernize Python tooling
7e40978 
Move all configs into `pyproject.toml`, switch test/packaging to
use Hatch, and do all the linting with Ruff.

Fix issues that Ruff turned up, and annotate/ignore the pieces that
it got wrong.

Fixes: Issue NicolasLM#33
0xDEC0DE pushed a commit to 0xDEC0DE/spinach that referenced this issue Feb 28, 2024
@nisimond
Modernize Python tooling
1351666 
Move all configs into `pyproject.toml`, switch test/packaging to
use Hatch, and do all the linting with Ruff.

Fix issues that Ruff turned up, and annotate/ignore the pieces that
it got wrong.

Fixes: Issue NicolasLM#33
0xDEC0DE pushed a commit to 0xDEC0DE/spinach that referenced this issue Feb 28, 2024
@nisimond
Modernize Python tooling
af9b6ff 
Move all configs into `pyproject.toml`, switch test/packaging to
use Hatch, and do all the linting with Ruff.

Fix issues that Ruff turned up, and annotate/ignore the pieces that
it got wrong.

Fixes: Issue NicolasLM#33
0xDEC0DE pushed a commit to 0xDEC0DE/spinach that referenced this issue Jun 3, 2024
@nisimond
Modernize Python tooling
e7a4813 
Move all configs into `pyproject.toml`, switch test/packaging to
use Hatch, and do all the linting with Ruff.

Fix issues that Ruff turned up, and annotate/ignore the pieces that
it got wrong.

Fixes: Issue NicolasLM#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bigjools