-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account ideas #1
Comments
What is the use case for linking accounts rather than merging them? Also two accounts can't have the same oauth login because then how do you log in? |
About authentication methods, Google etc. Will just verify that user x has email y and we log them in by email. I'll work this out once the site is going well, but I'll be away for a few days. |
Why not have a list of auth details per account, and disallow adding an account with details that are used elsewhere? Why link anything? |
That was the idea @gamemanj, have a unique index on the auth columns |
Auth details should probably be in a seperate table to actual accounts, and auth details should depend on accounts. From a UI perspective, "register" and "log in" need to be separate operations, and there needs to be a "link" operation which creates another auth-details object linked to the same account. |
What is the advantage to having a seperate table rather than jsut adding columns to the users table? |
Well, if you have a way of containing a /list/ of auth details (not just the one), then feel free to use that. |
As for the "see other" flag, what happens if account A makes something, then gets see-other'd to account B, which has also made something? |
Why do we need a list? We would have to add support in the codebase for each new auth method, why not also some extra columns? |
That works, assuming that nobody has 2 of any given account type, but that's a reasonable assumption to make. |
Yeah, we would only support a few things such as Google and twitter, I don't see us adding more than 3 oauth auth methods. |
The text was updated successfully, but these errors were encountered: