Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ⭐] Simplify VideoEncoder::new_from_stream by not using IRandomAccessStream #79

Open
maxomatic458 opened this issue Sep 10, 2024 · 2 comments

Comments

@maxomatic458
Copy link
Contributor

Is your feature request related to a problem? Please describe. 📝
No

Describe the solution you'd like 🔑

pub fn new_from_stream(
video_settings: VideoSettingsBuilder,
audio_settings: AudioSettingsBuilder,
container_settings: ContainerSettingsBuilder,
stream: IRandomAccessStream,

In my opinion interaction with the windows API should be as minimal as possible, so maybe use a callback function, or a mpsc::Sender
instead

@maxomatic458
Copy link
Contributor Author

is there maybe an example on how to use this function?
Im unable to call Capture::start because the IRandomAccessStream does not implement Send
how would i get the stream in the Capture struct then if not via the flags?

@NiiightmareXD
Copy link
Owner

I'm not sure about this I want to give full access to the user but at the same time not exposing IRandomAccessStream is a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants