Fix User Disabled Security Pattern Flow #329
Open
+85
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.- Fix the flow when a user disable all the security, it implements after removeKey also remove the preferences store in memory and throw BIOMETRIC_NO_SECRET_FOUND until new key have been created 2.- Also split methods of create and create key for better maintance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin can't recover when user disable security pattern and try to load a new secret, the method KeyStore.getKey throw an exception and says "user changed or deleted their auth credentials", it was added a method to also remove ciphertext and IV initializationVector from app storage in order to show the message BIOMETRIC_NO_SECRET_FOUND and manage exceptions to deleteKey and storage keys from app
How did you test your changes?
I tested on a Pixel 4 emulator and also in a SM-N9600 Samsung Note 9