Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option to pass Puppeteer executable path #66

Open
mabc224 opened this issue Feb 14, 2020 · 0 comments
Open

Feature Request: Option to pass Puppeteer executable path #66

mabc224 opened this issue Feb 14, 2020 · 0 comments

Comments

@mabc224
Copy link

mabc224 commented Feb 14, 2020

We should be able to pass Puppeteer executable path in browser config.
Currently, We can pass custom_func but it does not support option of executable path inside.
After this, We will be able to run it in AWS Lambda function.

let browser_config = {
    executablePath: '/path/to/Chrome',
}

We may need to change in these file to support executablePath
https://github.com/NikolaiT/se-scraper/blob/master/examples/pluggable.js#L3
https://github.com/NikolaiT/se-scraper/blob/master/examples/pluggable.js#L49
https://github.com/NikolaiT/se-scraper/blob/master/src/node_scraper.js#L69
https://github.com/NikolaiT/se-scraper/blob/master/src/node_scraper.js#L270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant