Require boost json component #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyMlashkin
force-pushed
the
require-boost-json-component
branch
from
afd0284 to
8034639
Compare
akokoshn
requested changes
Apr 26, 2024
| @@ -51,6 +51,8 @@ set(RSLANG_BUILD_TOOLS "<none>" CACHE STRING "Rust tools to build (see build.too | |||
| include(TargetArchitecture) | |||
| include(CircuitCompile) | |||
|
|
|||
| find_package(Boost REQUIRED COMPONENTS json) | |||
There was a problem hiding this comment.
Because the boost version from apt-get already contained all other required boost submodules.
But it's a valid point to explicitly list all the required ones
|
This one was triggered from my private repo, re-do it in this PR #600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598