Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for Nitrokeys restructuring #314

Open
2 tasks
daringer opened this issue Oct 29, 2024 · 2 comments
Open
2 tasks

Final changes for Nitrokeys restructuring #314

daringer opened this issue Oct 29, 2024 · 2 comments

Comments

@daringer
Copy link
Contributor

daringer commented Oct 29, 2024

The major restructuring is available online for staging, as of now I see the following issues to be resolved before finally merging. The aim should be to finally tune it to be mergable, further "features" or non essential things should be done after it was merged:

  • inside nitrokeys -> features the visible Nitrokey variants have proper links (this will work automatically once deployed, we could easily skip that)
  • inside nitrokeys -> features the checkmark and crosses should be nicer to distinguish from each other, maybe just use a green checkmark? (this is heavy, as sphinx does not allow css for single cells in a table)
@robin-nitrokey
Copy link
Member

robin-nitrokey commented Oct 29, 2024

  • nitrokeys/features/fido2/website contains information specific to the Nitrokey FIDO2 (update.nitrokey.com).
  • nitrokeys/features/u2f/odoo and nitrokeys/features/u2f/2fa list Nitrokey Pro and Storage as supported – for Odoo this might be fine as you can use OTP, but for 2FA it’s wrong. Maybe there should be a separate Odoo page for the TOTP feature?
  • nitrokeys/features/totp and all of its children don’t have checkmarks for the Nitrokey 3. I guess the reason is that it still describes Nitrokey App (1), but it’s still confusing.
  • nitrokeys/features/password-safe – is this supposed to describe the secrets app or password manager integration?
  • When navigating to Nitrokeys → Features → KeepassXC, the KeepasXC entry in the navigation bar is not highlighted (probably because the URL is software/nk-app2/keepassxc).
  • nitrokeys/nitrokey3/adsk belongs to the OpenPGP feature.
  • nitrokeys/nitrokey3/overview – most features link to end-user documentation, admin-app links to the GitHub repository. I don’t think that’s useful. Maybe just remove the link?

@mmerklinger
Copy link
Collaborator

mmerklinger commented Oct 29, 2024

  • nitrokeys/features/u2f (and all its subpages) lists the Nitrokey Pro 2 as compatible.
  • nitrokeys/features/password-safe/keepassxc -> software/nk-app2/keepassxc misses the product compatibility table on the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants