Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose iSerial number #88

Open
jans23 opened this issue May 7, 2019 · 1 comment
Open

Expose iSerial number #88

jans23 opened this issue May 7, 2019 · 1 comment

Comments

@jans23
Copy link
Member

jans23 commented May 7, 2019

It should be possible to enable/disable whether the device's serial number is exposed via USB descriptor or not. The format should be similar to Nitrokey Pro. By default the exposure should be disabled.

@robinkrahl
Copy link

Why is the serial number hidden at all? And what’s the difference to the Nitrokey Pro?

robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 14, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 15, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
robinkrahl added a commit to robinkrahl/nitrocli that referenced this issue Jan 15, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Jan 15, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Jan 15, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Apr 4, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Apr 4, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Apr 4, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
d-e-s-o pushed a commit to d-e-s-o/nitrocli that referenced this issue Apr 4, 2020
This patch implements the list command that lists all attached Nitrokey
devices.  Currently the Nitrokey Storage does not report its serial
number during HID enumeration, see [0].  So if we detect a Nitrokey
Storage device, we connect to it and use the get_serial_number function
to query its serial number.  This can be disabled using the --no-connect
option.

Note that even the get_serial_number function reports a wrong serial
number for the Nitrokey Storage, see [1].

[0] Nitrokey/nitrokey-storage-firmware#88
[1] Nitrokey/nitrokey-storage-firmware#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants