Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets: Make _semver_equal_or_newer public #407

Open
robin-nitrokey opened this issue Jun 20, 2023 · 2 comments
Open

secrets: Make _semver_equal_or_newer public #407

robin-nitrokey opened this issue Jun 20, 2023 · 2 comments
Labels
application:secrets Secrets app: OTP and Password Safe device/Nitrokey 3 enhancement New feature or request

Comments

@robin-nitrokey
Copy link
Member

As a library user, I’d like SecretsApp,_semver_equal_or_newer to be part of the public API so that I can use it to ensure a minimum version not only based on a specific feature.

@robin-nitrokey robin-nitrokey added enhancement New feature or request device/Nitrokey 3 application:secrets Secrets app: OTP and Password Safe labels Jun 20, 2023
@szszszsz
Copy link
Member

I do not see the purpose here. Can you elaborate on the use case?

I think further clients should not try to embed any knowledge regarding version and features relation, and instead it should be kept in the library directly communicating with the device.

@robin-nitrokey
Copy link
Member Author

For nitrokey-app, I want to enforce the policy to support only the latest version, at least until the API has stabilized. In the last releases, there were many subtle changes that are difficult to map to features, e. g. PIN requirements, touch requirement, list response, etc. Similar changes in the near future could be:

We could add a feature flag for all of these and check all, but I think this is just an unnecessarily complex workaround for a version check. A version check would also represent the fact that we currently only test against a specific version. In my opinion, feature flags are more suitable for enabling and disabling larger groups of functionality like PWS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application:secrets Secrets app: OTP and Password Safe device/Nitrokey 3 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants