Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admonition about CIVS invalid domains #6

Closed
wants to merge 1 commit into from

Conversation

proofconstruction
Copy link
Contributor

When trying to activate my email on the CIVS voting platform, I received the error "Illegal mail address". I tested with a few other domains, and found that the site simply won't accept several valid ones.

This PR updates the README with an admonition warning about this possibility.

illegal-mail-address

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn. I guess let's have something like this for now, but I'll think about adding a check for that. In particular, we can see the regex that is used to check this in the source

README.md Outdated Show resolved Hide resolved
infinisil added a commit that referenced this pull request Sep 17, 2024
@infinisil
Copy link
Member

I opened andrewcmyers/civs#61 to increase the maximum allowed TLD length. Furthermore I created a script to check whether an Email address would be invalid for CIVS, but running it over all Emails, it only found two:

$ scripts/check-mail.pl < $(nix-build -A voters)/emails.txt
"^"@regexmail.net
[email protected]

The first one I believe is an actually invalid email (also failed to send), but the only other email is yours, so I don't think we need to put this as a warning.

Unless the PR gets merged and deployed soon, could you register an alternate email address instead?

@proofconstruction
Copy link
Contributor Author

The first one I believe is an actually invalid email (also #1), but the only other email is yours, so I don't think we need to put this as a warning.

Up to you! I updated the commit in this PR to move this admonition to email.md, in any case.

Unless the PR gets merged and deployed soon, could you register an alternate email address instead?

Done in #33

@ryantrinkle
Copy link

The first one I believe is an actually invalid email (also failed to send)

I actually think it's valid - the "local part" of an email address is almost absurdly flexible; see https://en.wikipedia.org/wiki/Email_address#Local-part

@infinisil
Copy link
Member

Let's close this, thanks for pointing this out in any case!

@infinisil infinisil closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants