Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix for leading dot in store paths to 2.17? #10497

Closed
Ma27 opened this issue Apr 14, 2024 · 2 comments
Closed

Backport of fix for leading dot in store paths to 2.17? #10497

Ma27 opened this issue Apr 14, 2024 · 2 comments
Labels

Comments

@Ma27
Copy link
Member

Ma27 commented Apr 14, 2024

Describe the bug

Upon reviewing NixOS/nixpkgs#296709, I realized that 8aaa874 got backported to 2.17, however there's a followup (#9867) that wasn't backported.

Would it be possible to take care of that?
Or is the branch considered dead by now?

@Ma27 Ma27 added the bug label Apr 14, 2024
@thufschmitt
Copy link
Member

2.17 is technically unsupported. However, since the backport policy was fairly fuzzy until not that long ago, feel free to open a backport PR. I can't guaranty that there'll be a release, but we can at least merge the backport

@Ma27
Copy link
Member Author

Ma27 commented Apr 23, 2024

Change of plans then: the baseline should remain 2.18 for now[1], but I don't see a reason to keep 2.17 (and older versions) in nixpkgs then if they don't receive any maintenance anyways. Thanks for reporting back!

[1] I'll exclude nix_2_3 from this consideration: it still has a broad userbase to my knowledge so I intend to keep it in nixpkgs.

@Ma27 Ma27 closed this as completed Apr 23, 2024
Ma27 added a commit to Ma27/nixpkgs that referenced this issue Apr 27, 2024
Those are not maintained anymore by upstream Nix[1]. In fact, Nix
intends to only maintain

> * The latest release
> * The version used in the stable NixOS release, which is announced in the NixOS release notes.

Given that security issues and regressions happen, for instance latest
2.17 unconditionally rejects leading dots in store-paths, a regression
fixed in other Nix versions[2].

I didn't touch

* 2.3 since there's still a rather large user-base and it has a special
  role as the last pre-flakes release.

* 2.19 - 2.22: I'm not really sure what the next stable nix for nixpkgs
  will be and at least 2.19 seems to work relatively well for me.
  Anyways, touching those seems way more controversial than touching
  2.10-2.17, so I'll skip that for now.

[1] https://nixos.org/manual/nix/stable/release-notes/
[2] NixOS/nix#10497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants