Fix duplicate Nixpkgs diff comment #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A duplicate comment is posted when the action runs the first time, because the posted comment isn't reused.
philiptaron
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
On Matrix, @infinisil provided this explanation of the code:
-
Every step in GitHub Actions can have outputs. There's one step which finds a comment with "Nixpkgs diff" in it (Find Comment), and its output is used for the next step to target (
comment-id: ${{ steps.fc.outputs.comment-id }}) -
${{ ... }}is GitHub specific syntax that gets interpolated at runtime. -
The
create-or-update-commentaction creates an output named"comment-id".
This PR makes them work together to have just one comment.
piegamesde
approved these changes
Apr 16, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-04-16/43533/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate comment is posted when the action runs the first time, because the posted comment isn't reused.
This could be seen in #185, and it shouldn't happen in this PR anymore.