Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: playwright-driver: package Firefox and Webkit #288826

Closed
WesleyAC opened this issue Feb 14, 2024 · 5 comments
Closed

Package request: playwright-driver: package Firefox and Webkit #288826

WesleyAC opened this issue Feb 14, 2024 · 5 comments
Labels
0.kind: packaging request Request for a new package to be added

Comments

@WesleyAC
Copy link

Project description

playwright-browser currently only packages Chromium. It would be good to also package the versions of Firefox and Webkit that are supported upstream.

cc @phaer @fabaff @pietdevries94 @kalekseev @teto


Add a 👍 reaction to issues you find important.

@WesleyAC WesleyAC added the 0.kind: packaging request Request for a new package to be added label Feb 14, 2024
@teto
Copy link
Member

teto commented Feb 14, 2024

chromium is patchless while firefox had to carry some patch, + additional builds probably so that's a whole other level of commitment. Might be best to just patch with nix-ld (if that's possible) the proposed firefox (or run it in docker ?). Else feel free to takeover #197899

@WesleyAC
Copy link
Author

Ah, that makes sense. I recall using https://github.com/ludiosarchive/nixos-playwright in the past, so that approach may be applicable.

Do you know if Webkit also requires patches?

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/playwright-tests-on-multiple-browsers/41309/2

@phaer
Copy link
Member

phaer commented Apr 2, 2024

I gave this a try in #298944

@teto
Copy link
Member

teto commented Oct 2, 2024

merged the mnentioned PR

@teto teto closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added
Projects
None yet
Development

No branches or pull requests

4 participants