Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixpkgs committers list #321665

Open
Mic92 opened this issue Jun 22, 2024 · 30 comments
Open

Nixpkgs committers list #321665

Mic92 opened this issue Jun 22, 2024 · 30 comments

Comments

@Mic92
Copy link
Member

Mic92 commented Jun 22, 2024

Hi, the purpose of this issue is to nominate new nixpkgs contributors for commit access to nixpkgs. The process is described in nixpkgs-committers org documentation.

@lorenzleutgeb's script also wrote a script to summarize past github contributions. However more importantly we value when nominees work well together in the community and take ownership for their mistakes.

If you have questions regarding becoming a nixpkgs maintainer, you can contact the Nixpkgs committer delegation team:

@mweinelt
Copy link
Member

mweinelt commented Jul 4, 2024

I want to nominate @emilazy, who recently carried the OpenSSH SIGALARM vulnerability across all branches and even wrote an advisory and took the time to answer questions and construct a timeline.

Emily has 75 merged PRs and over 100 reviewed PRs. She has been contributing on and off since 2019, and contributed for example the initrd OpenSSH migration.

I think it would be beneficial to further enable a capable person like her.

@emilazy
Copy link
Member

emilazy commented Jul 4, 2024

Thank you for the nomination! I’d be happy to accept the commit bit if offered. I’ve frequently had long absences from FOSS work in the past several years, so I can’t guarantee availability, but I’d like to be able to contribute more consistently going forward. In the wider ecosystem I’m also a nix-darwin committer so I’m reasonably familiar with the module system, and I helped nix-darwin and Home Manager migrate from the old DocBook documentation toolchain to unblock its removal from Nixpkgs. The biggest thing I’ve done recently was working on removing Mesa as a channel blocker on Darwin, which had caused significant issues and friction in the past. I’m a user of both macOS and Linux and would like to continue to help bridge the gap between the two platforms in terms of maintenance and quality.

@willcohen
Copy link
Contributor

willcohen commented Jul 4, 2024

I’d like to apply for the commit bit (and also happy to wait if that makes more sense.)

My first contribution and introduction to Nix was in 2021-2022, to upstream to QEMU an old patchset to enable 9pfs on Darwin, thus allowing for fixing up remote file support on QEMU and thus lima and podman on Mac, with many thanks to @alyssais and @domenkozar in guiding me through all that: #122420

Since then, I’ve added a couple smaller packages and fixed up others to work better on Mac. My focuses are around GIS software on Mac (my longstanding white whale is to get QGIS working on Mac, which is both close and far: #157862), keeping emscripten up to date (usually some LLVM tip of tree backports with the help of @RaitoBezarius), Clojure stuff, the occasional dabbling in random JS or Perl packages here and there, and fixing broken things on Mac. I’ve been a little quieter the last year as work focuses pulled me a bit away from programming, but I’m working my way back in to it this summer. I know there’s a perennial need for capacity on Darwin (ie #323144) and that a combo of lack of testing and lack of ability to review or land fixes is a big pain point, and would mostly like to help keep those PRs moving in a timely manner.

58 merged PRs: https://github.com/NixOS/nixpkgs/pulls?q=sort:updated-desc+is:pr+author:willcohen+is:merged

52 reviews:
https://github.com/NixOS/nixpkgs/pulls?q=sort:updated-desc+is:pr+reviewed-by:willcohen+-author:willcohen (edited to remove my own PRs, thanks @eclairevoyant)

No NixOS modules yet — I’m still predominantly Mac-centric, though I sometime play with it in a VM.

@eclairevoyant
Copy link
Contributor

76 reviews of closed PRs, though probably a third of those are nixpkgs-review output of my own PRs:

You can filter those out with -author:willcohen; filtering out own PRs should be done in general for all PR review queries.

@lorenzleutgeb
Copy link
Member

You can filter those out with -author:willcohen; filtering out own PRs should be done in general for all PR review queries.

I added this condition to the script mentioned in OP.

@gador
Copy link
Member

gador commented Jul 20, 2024

I like to express my interest in a commit bit, too.
I've been working with NixOS and nixpkgs since 2021 and started contributing since then. Currently I maintain or co-maintain 51 packages.
Recently I wrote the blendfarm module and updated a few modules in the past.
I have the most experience with python, but also some experience with c++, qt, shell and a bit of go. My usual systems involve x86_64-linux, but I also have aarch64-linux and aarch64-darwin systems on which I can test packages or modules.

I'd like to use my commit bit to help merge already reviewed packages and to reduce the time it takes to merge simple updates. When time permits, I look through the pr ready for review thread on discourse and add my 2 cents.

@Mic92
Copy link
Member Author

Mic92 commented Jul 22, 2024

@emilazy @gador @willcohen Welcome to the team! Sorry for the delay. We (nixpkgs team admins) are currently discussing, where we are moving future applications, but until then we stick to this issue.

@infinisil
Copy link
Member

I'd like to nominate @philiptaron! They've been super helpful in co-maintaining https://github.com/NixOS/nixpkgs-check-by-name, but have also been active in Nixpkgs with

@donovanglover
Copy link
Member

I'm interested in committer rights to merge the pull requests of others and update packages I maintain.

Notable PRs:

Stats:

@mattpolzin
Copy link
Contributor

I'm interested in commit privileges. I reckon I'm on the low end for existing contributions to nixpkgs so no hard feelings if I just don't have the exposure yet to warrant committing; I think my bid for more responsibility is as much grounded in my record of maintenance across a number of OSS communities (most recently Idris2 and beam-community) as it is in nixpkgs PRs merged thus far. The reason I believe that is relevant is because I know how to show restraint and gradually assert myself in more places as I gain confidence that I know the established precedents.

My primary areas of interest in nixpkgs are: The Elixir ecosystem (PRs), Idris2 (PRs), and Darwin (PRs). I also have a vested interest in the Ruby ecosystem, NixOS, and the overall health and success of nixpkgs!

@Mic92
Copy link
Member Author

Mic92 commented Jul 31, 2024

@philiptaron welcome to the team.

@Mic92
Copy link
Member Author

Mic92 commented Aug 2, 2024

@donovanglover welcome to the team as well.

@Mic92
Copy link
Member Author

Mic92 commented Aug 2, 2024

@mattpolzin Not a reject, but none of us (@jtojnar, @NickCao and me) knows you very well, so we would like to know if there is a person from the community you have interacted with and who can vouch for you?

@mattpolzin
Copy link
Contributor

mattpolzin commented Aug 2, 2024

@Mic92 Sure, that's fair. I'm not sure if any single existing Nixpkgs committer has interacted with me in more than one context so it's quite possible no one would say they know me well (yet). I'd mention @happysalada or @fabianhjr who I think have had positive experiences working with me in the context of Elixir and Idris2 packaging but I definitely won't feel slighted if they don't feel they are ready to vouch for me at this point. I believe the folks maintaining Bruno with me have seen me be responsive, knowledgable, constructive, etc. but last I checked none of us are committers (so no one to suggest vouches for me there).

@fabianhjr
Copy link
Member

Can vouch about positive interactions here on nixos and on some idris stuff a while back

@happysalada
Copy link
Contributor

Same here, i can vouch for positive interactions. I think the beam maintainers could definitely benefit from having more people.

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Aug 4, 2024

I'd like to nominate @AndersonTorres. I was surprised that they aren't a commiter already, despite their HUUGE contributions. My personal interactions with them have been very civil and I have learnt a thing or two from them in my novice days (still learning).

I was surprised to see they aren't a commiter already.

@doronbehar
Copy link
Contributor

I too feel that @AndersonTorres is very dedicated, and very motivated - which explains their thorough contributions. However I personally experienced stubborn communication with him (also here), which makes me a bit worried to be fully honest. I deeply appreciate though the PRs that remove the inactive maintainers (see #290642).

I was surprised to see they aren't a commiter already.

They were in the past, and got removed.

@Atemu
Copy link
Member

Atemu commented Aug 4, 2024

I can mirror @doronbehar's opinion but want to add that my interactions with them have not improved significantly since they lost their commit access. I think it'd be better to keep it that way for now.

@Mic92
Copy link
Member Author

Mic92 commented Aug 10, 2024

@mattpolzin based on @happysalada and @fabianhjr's feedback, we have decided to give you nixpkgs commit access. Welcome.

@drupol
Copy link
Contributor

drupol commented Aug 11, 2024

Hello there,

I'd like to nominate @felschr.

He has 123 authored & closed PRs, 174 reviewed & closed PRs, and he maintains about 18 packages.

His main focus is on maintaining Tor Browser & Mullvad Browser. Many of the updates are security critical and it could be good having an active package maintainer who can merge them.

He also created the etebase-server NixOS module a while ago and made some smaller improvements to other modules (e.g. cfdyndns, mosquitto, ddclient).

I personally had the chance to interact with him on PRs and all the interactions were pretty good and respectful.

@emilazy
Copy link
Member

emilazy commented Aug 19, 2024

I’d like to nominate @tie, if he’s interested. He has been contributing since late 2022, and has recently been doing very high‐quality and in‐depth work covering the spectrum from extensive work on the Node.js package, through a rework of a core Darwin tool switching from an unmaintained fork to a clean set of patches on top of the latest upstream release, to fixes and various enhancements to stdenv. He has also brought his invaluable Bash expertise to reviews of various pull requests, including #318614 and #331560. The raw PR counts may be lower than many new committers, but in my judgement they are of a high standard and frequently high‐effort, and I have found him a pleasure to work with.

@minijackson
Copy link
Member

Hi everyone! I'd like to apply for committer access. I've been a member of the NixOS GitHub organization since 2020, and have been active in various parts, like cross-compilation (1, 2), systemd journal remote, NetBox, Jellyfin, etc.

@tie
Copy link
Member

tie commented Aug 23, 2024

@emilazy, thank you, it’s been a pleasure working with you and @philiptaron as well! I have more computers than I probably need in my homelab, so my focus in NixOS/Nixpkgs/Nix is support for building packages for different platforms (i.e. cross-compilation). I’m mostly contributing in my free time, but we also use NixOS at my current job. I’m not opposed to getting committer access, but I hope I can be of help with stuff I’m familiar with regardless of the commit bit.

@Mic92 Mic92 changed the title New nixpkgs committers interest list New nixpkgs committers list Aug 26, 2024
@Mic92 Mic92 changed the title New nixpkgs committers list nixpkgs committers list Aug 27, 2024
@Mic92 Mic92 changed the title nixpkgs committers list Nixpkgs committers list Aug 27, 2024
@Mic92
Copy link
Member Author

Mic92 commented Aug 27, 2024

Welcome to the team! @tie @felschr

@Mic92
Copy link
Member Author

Mic92 commented Aug 27, 2024

And also @minijackson

@flokli
Copy link
Contributor

flokli commented Aug 28, 2024

I'd like to propose @r-vdp. Almost 100 merged PRs, generally high-quality contributions and reviews. Was surprised he's not already on the list :-)

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2024

A cool project that @r-vdp has build: https://github.com/numtide/system-manager

@tomodachi94
Copy link
Member

I'd like to apply for committer access. I maintain a smattering of packages, including some packages core to the ComputerCraft ecosystem, as well as making fixes and QOL tweaks to various packages and NixOS modules.

I understand how many of the packaging ecosystems work (Python, Rust, Node, kernel modules, VSCode and Vim plugins, and certainly more that I'm missing), and I know how to find out if I don't.

As a moderator of the unofficial but de facto Discord server, I have helped and encouraged prospective Nixpkgs contributors in the Discord by giving them fast review-fix-repeat cycles, helping them rapidly improve.

Additionally, I have:

@pbsds
Copy link
Member

pbsds commented Sep 12, 2024

I want to nominate @anthonyroussel. They have been active since at least 2022 and have a solid grasp of pkgs, nixos, the affordabilities in lib. They're not afraid to ask for help, nor afraid to admit when they might be wrong, and have proven helpful in many situations. They've contributed to various community projects such as Shadow Nix, Stylix and Home Manager, and maintain a bunch of packages in nixpkgs (132 according to repology, 85 according to rg -l | wc -l).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests