Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentabletdriver.fetch-deps crashes #366372

Closed
gepbird opened this issue Dec 19, 2024 · 3 comments
Closed

opentabletdriver.fetch-deps crashes #366372

gepbird opened this issue Dec 19, 2024 · 3 comments
Labels
0.kind: bug Something is broken 6.topic: dotnet Language: .NET

Comments

@gepbird
Copy link
Contributor

gepbird commented Dec 19, 2024

Describe the bug

Running opentabletdriver.fetch-deps script crashes after #362278

Steps To Reproduce

Steps to reproduce the behavior:

  1. checkout master (12e3af0)
  2. $(nix-build -A opentabletdriver.fetch-deps)
  3. observe error: /nix/store/vszbrq40jq530xf3022j9zwjanmpgc9d-wrap-gapps-hook/nix-support/setup-hook: line 31: !v: unbound variable

Expected behavior

No crash

Screenshots

Additional context

Bisected to c94c508. Most likely only a few packages are affected that are using wrapGAppsHook3, no issues with for example vrcadvert.fetch-deps or tone.fetch-deps.

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.5-zen1, NixOS, 25.05 (Warbler), 25.05.20241213.3566ab7`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.91.1
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /home/gep/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/gep/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/gep/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/gep/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/smghprxmwyp707kqljlm4fsxm7h5wd72-lix-2.91.1/share`
 - nixpkgs: `/nix/store/22r7q7s9552gn1vpjigkbhfgcvhsrz68-source`

Notify maintainers

@GGG-KILLER


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@gepbird gepbird added the 0.kind: bug Something is broken label Dec 19, 2024
@gepbird
Copy link
Contributor Author

gepbird commented Dec 19, 2024

Applying the following on master "fixes" this issue:

diff --git a/pkgs/build-support/dotnet/add-nuget-deps/fetch-deps.sh b/pkgs/build-support/dotnet/add-nuget-deps/fetch-deps.sh
index 809f5c4b26d8..c65b666d9d9f 100644
--- a/pkgs/build-support/dotnet/add-nuget-deps/fetch-deps.sh
+++ b/pkgs/build-support/dotnet/add-nuget-deps/fetch-deps.sh
@@ -1,5 +1,5 @@
 # shellcheck shell=bash
-set -euo pipefail
+set -eo pipefail
 
 export PATH="@binPath@:$PATH"

I guess wrapGAppsHook3 script needs to handle undefined variables in a better way.

@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Dec 19, 2024

Oh, my bad, I thought that was something that was already happening on master.
Didn't notice that my changes caused it, I'll get a PR up ASAP.

Thanks for finding the solution, I'll put the commit up with you as the author to give you full credit for the solution.

@gepbird
Copy link
Contributor Author

gepbird commented Dec 20, 2024

Fixed by #366556

@gepbird gepbird closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: dotnet Language: .NET
Projects
None yet
Development

No branches or pull requests

2 participants