Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick-colour-picker: icon missing #78484

Open
davidak opened this issue Jan 25, 2020 · 9 comments
Open

pick-colour-picker: icon missing #78484

davidak opened this issue Jan 25, 2020 · 9 comments
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@davidak
Copy link
Member

davidak commented Jan 25, 2020

Describe the bug
the color picker icon on the main button is missing

To Reproduce
Steps to reproduce the behavior:

  1. nix run -f channel:nixos-unstable pick-colour-picker
  2. pick-colour-picker
  3. see button

Expected behavior
buttons should have the proper icon and not a placeholder

Screenshots
Screenshot from 2020-01-25 22-34-43

Additional context
I use the Pantheon Desktop (GTK based).

https://github.com/davidak/nixos-config/blob/master/machines/thinkpad_X230/configuration.nix

Metadata

  • system: "x86_64-linux"
  • host os: Linux 4.19.93, NixOS, 19.09.1815.caad1a78c47 (Loris)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.2
  • channels(davidak): ""
  • channels(root): "nixos-19.09.1815.caad1a78c47, nixos-hardware, nixos-unstable-20.03pre208413.e1eedf29e5d"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: pick-colour-picker
# a list of nixos modules affected by the problem
module:
@davidak davidak added the 0.kind: bug Something is broken label Jan 25, 2020
@mkg20001
Copy link
Member

Tested on pantheon nixos-unstable, seems to work
screenshot

The problem is probably that it's not in your environment.systemPackages. Unsure if this is a bug then 🤔

@doronbehar
Copy link
Contributor

There's also the *icons packages such as breeze-icons which may help.

@doronbehar
Copy link
Contributor

@davidak did you try to install breeze-icons?

@davidak
Copy link
Member Author

davidak commented May 26, 2020

Having breeze-icons don't help:

nix run -f channel:nixos-unstable pick-colour-picker breeze-icons -c pick-colour-picker

But installing it using environment.systemPackages does, even without breeze-icons, on stable.

I think it should also work with nix run.

@doronbehar
Copy link
Contributor

I think it should also work with nix run.

I agree, sounds like it's wrapping related - on my system:

$ echo $XDG_DATA_DIRS | sed 's/:/\n/g'
/nix/store/hypvzdxqbdkc2bilp42ldbk1a9xk04h5-gtk+3-3.24.20/share/gsettings-schemas/gtk+3-3.24.20
/nix/store/vhc7j53yqsvrr35whr178bh7spxpan6n-gsettings-desktop-schemas-3.36.1/share/gsettings-schemas/gsettings-desktop-schemas-3.36.1
/home/doron/.local/share/flatpak/exports/share
/var/lib/flatpak/exports/share
/home/doron/.nix-profile/share
/etc/profiles/per-user/doron/share
/nix/var/nix/profiles/default/share
/run/current-system/sw/share

And in /run/current-system/sw/share, I have:

$ ls -l /run/current-system/sw/share/icons
total 12
lrwxrwxrwx 1 root root  89 Jan  1  1970 Adwaita -> /nix/store/r0j7nv84y8dvnk52xxkv0iyrkrdn5wnh-adwaita-icon-theme-3.36.1/share/icons/Adwaita
lrwxrwxrwx 1 root root  82 Jan  1  1970 breeze -> /nix/store/zjcbpvqamdvwfa3cggzdy3h7x0n3xsqz-breeze-icons-5.68.0/share/icons/breeze
lrwxrwxrwx 1 root root  87 Jan  1  1970 breeze-dark -> /nix/store/zjcbpvqamdvwfa3cggzdy3h7x0n3xsqz-breeze-icons-5.68.0/share/icons/breeze-dark
dr-xr-xr-x 1 root root 250 Jan  1  1970 hicolor
dr-xr-xr-x 1 root root  62 Jan  1  1970 locolor
dr-xr-xr-x 1 root root   0 Jan  1  1970 pdfsam-basic.svg
dr-xr-xr-x 1 root root  40 Jan  1  1970 scalable

So I suspect the icons are loaded from there. If we'd wrap pick-colour-picker properly we wouldn't encounter this, but that's impossible with our current wrapping methods, if you ask me. Anyway, I added this to my TODO for my declarative wrappers enhancement and I'll write an RFC someday for this, examplifying this issue.

@davidak
Copy link
Member Author

davidak commented May 26, 2020

On my system:

[davidak@nixos:~]$ echo $XDG_DATA_DIRS | sed 's/:/\n/g'
/nix/store/r83h6pbqanjmj52asvddnmd3rj3lqv85-elementary-terminal-5.5.2/share
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/r83h6pbqanjmj52asvddnmd3rj3lqv85-elementary-terminal-5.5.2/share/gsettings-schemas/elementary-terminal-5.5.2
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share
/nix/store/zsgxlrvvxgidrqxfc7bpd8jj1jd1yhk1-elementary-icon-theme-5.2.0/share
/nix/store/sawis0vr4nl10rmywv7l7dd3ckk8dzzb-hicolor-icon-theme-0.17/share
/nix/store/x05pg0pz44jb4kvfsmlziayx6qcq07x4-granite-5.3.1/share
/nix/store/gaf8cpbad72gc7phr39x0zdaw3fx21aa-cups-2.3.3/share
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share
/nix/store/zsgxlrvvxgidrqxfc7bpd8jj1jd1yhk1-elementary-icon-theme-5.2.0/share
/nix/store/sawis0vr4nl10rmywv7l7dd3ckk8dzzb-hicolor-icon-theme-0.17/share
/nix/store/x05pg0pz44jb4kvfsmlziayx6qcq07x4-granite-5.3.1/share
/nix/store/gaf8cpbad72gc7phr39x0zdaw3fx21aa-cups-2.3.3/share
/nix/store/sy1frpj8d21kyqrsnwixsmy4d7q0idag-elementary-dock-unstable-2020-02-28/share
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/sy1frpj8d21kyqrsnwixsmy4d7q0idag-elementary-dock-unstable-2020-02-28/share/gsettings-schemas/elementary-dock-unstable-2020-02-28
/nix/store/rlsg858xy4bjn5y7g97nwnl0whzlqq58-elementary-session-settings-5.0.3/share
/home/davidak/.nix-profile/share
/etc/profiles/per-user/davidak/share
/nix/var/nix/profiles/default/share
/run/current-system/sw/share
/nix/store/gsq1nqc444yrxp2lpmmvf3sci9d9vg33-pantheon-agent-geoclue2-1.0.4/share/gsettings-schemas/pantheon-agent-geoclue2-1.0.4
/nix/store/ycdig389kh1pzknhwl9lfgzmrxq46qd1-gnome-session-3.34.2/share
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/m8b41yjr2ws8r0ajbmv76bx1lj22wjgj-gnome-settings-daemon-3.34.2/share/gsettings-schemas/gnome-settings-daemon-3.34.2
/nix/store/m8b41yjr2ws8r0ajbmv76bx1lj22wjgj-gnome-settings-daemon-3.34.2/share/gsettings-schemas/gnome-settings-daemon-3.34.2
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/7k46faqlr4gffdyksffrhllp9vav95i5-gsettings-desktop-schemas-3.34.0/share/gsettings-schemas/gsettings-desktop-schemas-3.34.0
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/8pygfc7lj4ha9lqrwmnz1mqxw8mxif91-gtk+3-3.24.13/share/gsettings-schemas/gtk+3-3.24.13
/nix/store/m8b41yjr2ws8r0ajbmv76bx1lj22wjgj-gnome-settings-daemon-3.34.2/share/gsettings-schemas/gnome-settings-daemon-3.34.2
/nix/store/m8b41yjr2ws8r0ajbmv76bx1lj22wjgj-gnome-settings-daemon-3.34.2/share/gsettings-schemas/gnome-settings-daemon-3.34.2
/nix/store/ycdig389kh1pzknhwl9lfgzmrxq46qd1-gnome-session-3.34.2/share/gsettings-schemas/gnome-session-3.34.2
/nix/store/ycdig389kh1pzknhwl9lfgzmrxq46qd1-gnome-session-3.34.2/share/gsettings-schemas/gnome-session-3.34.2
/nix/store/a0ylbfr77ykpmvl92fyjwfz5ibqhzl9y-gnome-shell-3.34.4/share
[davidak@nixos:~]$ ls -l /run/current-system/sw/share/icons
total 16
dr-xr-xr-x  2 root root 4096 Jan  1  1970 Adwaita
lrwxrwxrwx  1 root root   94 Jan  1  1970 elementary -> /nix/store/zsgxlrvvxgidrqxfc7bpd8jj1jd1yhk1-elementary-icon-theme-5.2.0/share/icons/elementary
dr-xr-xr-x 23 root root 4096 Jan  1  1970 hicolor
dr-xr-xr-x  3 root root 4096 Jan  1  1970 HighContrast

No breeze-icons but it still works. And that should also be accessible in nix shell, but packages should also work in pure shell.

@stale
Copy link

stale bot commented Nov 22, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 22, 2020
@davidak
Copy link
Member Author

davidak commented Nov 22, 2020

The issue is still reproducible.

Screenshot from 2020-11-22 19-43-23


  • system: "x86_64-linux"
  • host os: Linux 5.8.18, NixOS, 20.09.1721.896270d629e (Nightingale)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.7
  • channels(root): "home-manager-20.09, nixos-20.09.1721.896270d629e, nixos-hardware, nixos-unstable-21.03pre251123.b839d4a8557"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 22, 2020
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

3 participants