Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nilearn: unbreak tests #147936

Merged
merged 1 commit into from
Nov 29, 2021
Merged

python3Packages.nilearn: unbreak tests #147936

merged 1 commit into from
Nov 29, 2021

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Nov 29, 2021 •
edited
Loading

Only recurse into nilearn/, not e.g. examples/, which triggers (non-mocked) data downloads.

Motivation for this change

Unbreak the package. Will backport for ZHF (#144627).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [NA] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bcdarwin
python3Packages.nilearn: unbreak tests
fa83ed4 
Only recurse into `nilearn/`, not e.g. `examples/`,
which triggers (non-mocked) data downloads.
@fabaff fabaff mentioned this pull request Nov 29, 2021
Merged
9 tasks
@fabaff
Copy link
Member

fabaff commented Nov 29, 2021

Result of nixpkgs-review pr 147936 run on x86_64-linux 1

2 packages built:
  • python38Packages.nilearn
  • python39Packages.nilearn

fabaff
fabaff approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit dac53fc into NixOS:master Nov 29, 2021
@bcdarwin bcdarwin deleted the unbreak-nilearn branch November 29, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcdarwin @fabaff