Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2p: 2.6.0 -> 2.6.1 #337305

Merged
merged 1 commit into from
Aug 26, 2024
Merged

i2p: 2.6.0 -> 2.6.1 #337305

merged 1 commit into from
Aug 26, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 25, 2024

Description of changes

Update i2p package to v2.6.1

This update was made based on information from https://repology.org/project/i2p/versions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@6543
Copy link
Member Author

6543 commented Aug 25, 2024

cc @linsui

@6543
Copy link
Member Author

6543 commented Aug 25, 2024

PS: I'd like to backport it to release-24.05 as that version is quite old and https://geti2p.net/en/blog/post/2024/07/19/2.6.0-Release introduced some cleanup so older routers are less preferred and might have a chance to be rejected at some point ...

@6543 6543 added the 8.has: package (update) This PR updates a package to a newer version label Aug 25, 2024
@linsui linsui added the backport release-24.05 Backport PR automatically label Aug 25, 2024
@ofborg ofborg bot requested a review from linsui August 25, 2024 18:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 25, 2024
@6543
Copy link
Member Author

6543 commented Aug 25, 2024

☝️ somethimes the but is kinda akward ... :/

@SigmaSquadron SigmaSquadron removed the request for review from linsui August 25, 2024 20:14
@SigmaSquadron SigmaSquadron added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 25, 2024
@smancill
Copy link
Contributor

Result of nixpkgs-review pr 337305 run on x86_64-darwin 1

@smancill smancill merged commit a9f789e into NixOS:master Aug 26, 2024
43 of 45 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-337305-to-release-24.05 origin/release-24.05
cd .worktree/backport-337305-to-release-24.05
git switch --create backport-337305-to-release-24.05
git cherry-pick -x 6f479830a2611b68672aba475779c9832eb09dc7

@6543
Copy link
Member Author

6543 commented Aug 26, 2024

manual backport: #337392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants