-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cato: init at 5.2.1.1 #339533
base: master
Are you sure you want to change the base?
cato: init at 5.2.1.1 #339533
Conversation
5894752
to
b90fe46
Compare
One thing I haven't solved yet is the named pipes created in |
For this I'd encourage writing a module that can leverage either some kind of systemd unit or systemd.tmpfiles to ensure proper permissions are set. EDIT: Since I see there is a systemd service, set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the commonly accepted decision these days is to have the package in pkgs/by-name.
If you're certain about keeping it here, please link it in pkgs/top-level/all-packages.nix, as currently its inaccessible by the standard pkgs.cato
entrypoint
b90fe46
to
c8ad14b
Compare
405871e
to
a698d78
Compare
I have created a module. Tried to start the service with Are the paths correct now that it's a module? I notice that If I include it like this in my { config, lib, pkgs, ... }:
{
imports = [ /home/yarek/Play/nixpkgs/pkgs/by-name/ca/cato-client/package.nix ];
services.cato-client.enable = true;
# ...
} Should I have a line that installs it into systemPackages somewhere inside the |
1c518a1
to
cfe1efe
Compare
Now this looks better: { config, lib, pkgs, ... }:
{
imports = [/home/yarek/Play/nixpkgs/nixos/modules/services/networking/cato-client.nix ];
services.cato-client = {
enable = true;
package = (pkgs.callPackage /home/yarek/Play/nixpkgs/pkgs/by-name/ca/cato-client/package.nix {});
}; |
cfe1efe
to
9817415
Compare
9817415
to
4d4f364
Compare
Description of changes
Add Cato VPN client
https://www.catonetworks.com/platform/cato-client/
From their webpage:
closes #338964
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.