Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networking.firewall: fix refactor regression #342159

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

azahi
Copy link
Member

@azahi azahi commented Sep 15, 2024

Description of changes

This fixes a regression that was introduced in #335631. Specifically this bit.

That refactoring mistake currently breaks firewall with nftables (context omitted):

       error: attribute 'filterForward' missing
       at /nix/store/6jl5brxjsh90vdzrp2k392qyf36p5aps-source/nixos/modules/services/networking/firewall-nftables.nix:161:30:
          160|
          161|         ${lib.optionalString cfg.filterForward ''
             |                              ^
          162|           chain forward {

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes a regression that was introduced in NixOS#335631
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 15, 2024
@philiptaron philiptaron merged commit eab44e8 into NixOS:master Sep 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants