Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mermaid version (v2) #6389

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Update mermaid version (v2) #6389

merged 3 commits into from
Feb 21, 2025

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Feb 21, 2025

this fixes #6291 but for v2

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb25603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 6:38am

@zoeyTM zoeyTM requested review from kanej and alcuadrado February 21, 2025 05:18
@zoeyTM zoeyTM changed the title Update mermaid version Update mermaid version (v2) Feb 21, 2025
alcuadrado
alcuadrado reviewed Feb 21, 2025
View reviewed changes
packages/hardhat-ignition-ui/package.json Outdated
@@ -5,7 +5,7 @@
"scripts": {
"predev": "pnpm regenerate-deployment-example",
"dev": "vite --force",
"build": "tsc --build . && vite build",
"build": "tsc && vite build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still require --build .. I fixed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH good catch. I changed this originally to test if it fixed anything with the diagram and forgot to change it back.

@alcuadrado
Copy link
Member

I haven't manually verify the rendering, but I fixed the build

@zoeyTM zoeyTM added no changeset needed This PR doesn't require a changeset and removed status:triaging labels Feb 21, 2025
kanej
kanej approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zoeyTM zoeyTM merged commit 93027e2 into main Feb 21, 2025
127 checks passed
@zoeyTM zoeyTM deleted the fix/mermaid-text-v2 branch February 21, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado left review comments

@kanej kanej kanej approved these changes

Assignees

@kanej kanej

Labels
no changeset needed This PR doesn't require a changeset
Projects
Hardhat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text is not appearing on visualize mermaid diagram
3 participants
@zoeyTM @alcuadrado @kanej