Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace literal constants with parameters #34

Open
gold2718 opened this issue Aug 28, 2024 · 3 comments
Open

Replace literal constants with parameters #34

gold2718 opened this issue Aug 28, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@gold2718
Copy link
Contributor

There are many literal constants in Oslo Aero that should be documented.
Some of them should be replaced with shared parameters such as the constant, 287.04, in src/aero_model.F90 (should be rair from physconst) while others should be turned into module or subroutine parameters with appropriate names and source documentation.

Note that changing 287.04 to rair will change answers so this should be done in a separate commit.

@gold2718 gold2718 added the enhancement New feature or request label Aug 28, 2024
@gold2718 gold2718 added this to the NorESM2.5 milestone Aug 28, 2024
@gold2718
Copy link
Contributor Author

Also, all constants (parameters or literal) should be explicitly type _r8. One such file that needs fixing is src/oslo_areo_ocean.F90 .

@oyvindseland
Copy link

Yes I agree and given the development phase it is the correct time to do so.

Do you want help with going through the variables?
I think we should do the cleaning up in 2.5. Or should we also do it for older versions? I presume given the rewriting from 2.1 to 2.3 we can do the work in 2.3 and then merge.

@gold2718
Copy link
Contributor Author

I think it depends on how the scheduling falls out. Since some of this work might change answers, it should be in a separate commit (so we can verify that nothing bad has happened and we are just dealing with tiny changes). I would say it is a lower priority than getting 2.3 released so I would like to finish the other 2.3 work first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants