fix-loading-bug

Author: RChandler234

src/frontend/src/pages/FinancePage/ReimbursementRequestDetailPage/ReimbursementRequestDetailsView.tsx

@@ -226,6 +226,11 @@ const ReimbursementRequestDetailsView: React.FC<ReimbursementRequestDetailsViewP
         setOpen={setShowSubmitToSaboModal}
         reimbursementRequest={reimbursementRequest}
       />
+      <AddSABONumberModal
+        modalShow={addSaboNumberModalShow}
+        onHide={() => setAddSaboNumberModalShow(false)}
+        reimbursementRequestId={reimbursementRequest.reimbursementRequestId}
+      />
       <Grid container spacing={2} mt={2}>
         <Grid item lg={6} xs={12}>
           <BasicInformationView />
@@ -242,11 +247,6 @@ const ReimbursementRequestDetailsView: React.FC<ReimbursementRequestDetailsViewP
           </Grid>
         </Grid>
       </Grid>
-      <AddSABONumberModal
-        modalShow={addSaboNumberModalShow}
-        onHide={() => setAddSaboNumberModalShow(false)}
-        reimbursementRequestId={reimbursementRequest.reimbursementRequestId}
-      />
     </PageLayout>
   );
 };

src/frontend/src/pages/FinancePage/ReimbursementRequestDetailPage/SubmitToSaboModal.tsx

@@ -2,7 +2,7 @@ import NERModal from '../../../components/NERModal';
 import { Box, Grid, Typography } from '@mui/material';
 import { useApproveReimbursementRequest } from '../../../hooks/finance.hooks';
 import { ReimbursementRequest, wbsPipe } from 'shared';
-import { useUserSecureSettings } from '../../../hooks/users.hooks';
+import { useCurrentUser, useUserSecureSettings } from '../../../hooks/users.hooks';
 import LoadingIndicator from '../../../components/LoadingIndicator';
 import ErrorPage from '../../ErrorPage';
 import { datePipe } from '../../../utils/pipes';
@@ -16,11 +16,13 @@ interface SubmitToSaboModalProps {
 }
 
 const SubmitToSaboModal = ({ open, setOpen, reimbursementRequest }: SubmitToSaboModalProps) => {
+  const user = useCurrentUser();
   const { mutateAsync: submitToSabo } = useApproveReimbursementRequest(reimbursementRequest.reimbursementRequestId);
   const { recipient, dateOfExpense, totalCost, vendor, expenseType, reimbursementProducts, receiptPictures } =
     reimbursementRequest;
   const { data: userInfo, isLoading, isError, error } = useUserSecureSettings(recipient.userId);
 
+  if (!user.isFinance) return <></>;
   if (isLoading || !userInfo) return <LoadingIndicator />;
   if (isError) return <ErrorPage error={error} message={error.message} />;