Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set temp units as a true/false choice rather than another enum #5

Open
SRGDamia1 opened this issue Apr 16, 2018 · 0 comments
Open

Set temp units as a true/false choice rather than another enum #5

SRGDamia1 opened this issue Apr 16, 2018 · 0 comments

Comments

@SRGDamia1
Copy link
Contributor

I think it would be better to choose units with a true=celsius and false=fahernheit rather than creating and enum for those values. This removes one of the enums from the library and also reduces chances of conflict with any other libraries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SRGDamia1