Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other Godot versions #12

Open
NotNite opened this issue Nov 2, 2024 · 0 comments
Open

Support other Godot versions #12

NotNite opened this issue Nov 2, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@NotNite
Copy link
Owner

NotNite commented Nov 2, 2024

Right now GDWeave is locked to 3.5.2 w/ a specific GodotSteam build. We should expand for other engine versions with the following way:

  • Detect the engine version somehow.
    • Lazy option: call the game binary with --version.
  • Write multiple enums and file format implementations.
    • We can just have a VariantType_3_5_2 and whatnot. Either codegen or reflect a lookup table to make this speedy.
    • I don't think the gdc format will change too heavily, but it might require breaking changes.
    • To not break the API, the current enums and variant classes can't have anything removed or shifted around. We'll just have to append new variant types to the bottom instead of inserting them in the "proper" locations.
  • Abstract the required hooks into different classes per engine version.
    • One version can have multiple engine builds (e.g. diff builds of GodotSteam), so we will have to have the ability to pick a set of hooks and try scanning each one until they match, then create the hooks.

What do we do if the function we want to target is inlined? I don't know! Maybe it'll be time to look into mid-function Reloaded hooks...

@NotNite NotNite added enhancement New feature or request help wanted Extra attention is needed labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant