PDF file URLs won't be signed

[sagan]

Description

At this time, NotionAPI.addSignedUrls only signs URLs which contains secure.notion-static.com string (#332).

Notion is currently serving PDF (may be also other type files, I don't test) files from "https://prod-files-secure.s3.us-west-2.amazonaws.com/<uuid1>/<uuid2>/<name>.pdf" style urls, which won't be signed by NotionAPI.addSignedUrls.

Notion Test Page ID

1387d259b2558024b095eb5c50425400

[worgho2]

See #596

[worgho2]

Meanwhile you can use this function to solve the problem

const  addSignedUrls: NotionAPI['addSignedUrls'] = async ({
    recordMap,
    contentBlockIds,
    kyOptions,
  }) => {
    recordMap.signed_urls = {};

    if (!contentBlockIds) {
      contentBlockIds = getPageContentBlockIds(recordMap);
    }

    const allFileInstances = contentBlockIds.flatMap((blockId) => {
      const block = recordMap.block[blockId]?.value;

      if (
        block &&
        (block.type === 'pdf' ||
          block.type === 'audio' ||
          (block.type === 'image' && block.file_ids?.length) ||
          block.type === 'video' ||
          block.type === 'file' ||
          block.type === 'page')
      ) {
        const source =
          block.type === 'page' ? block.format?.page_cover : block.properties?.source?.[0]?.[0];
        // console.log(block, source)

        if (source) {
          if (source.includes('secure.notion-static.com') || source.includes('prod-files-secure')) {
            console.log(source);
            return {
              permissionRecord: {
                table: 'block',
                id: block.id,
              },
              url: source,
            };
          }
        }
      }

      return [];
    });

    if (allFileInstances.length > 0) {
      try {
        const { signedUrls } = await this.client.getSignedFileUrls(allFileInstances, kyOptions);

        if (signedUrls.length === allFileInstances.length) {
          for (const [i, file] of allFileInstances.entries()) {
            const signedUrl = signedUrls[i];
            if (!signedUrl) continue;

            const blockId = file.permissionRecord.id;
            if (!blockId) continue;

            recordMap.signed_urls[blockId] = signedUrl;
          }
        }
      } catch (err) {
        console.warn('NotionAPI getSignedfileUrls error', err);
      }
    }
  };

const pageId = 'your page id';

const recordMap = await this.client.getPage(pageId, {
        signFileUrls: false 
    }
});

await addSignedUrls({ recordMap })

[mfts]

@worgho2 Amazing ! This worked like a charm for me 🖤

[mfts]

@sagan @worgho2 in case this is still revelant to you, Notion updated how the upload files, so you need to also look for attachment: in the source text.

Or wait until this PR is merged :)

#613