Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculateSeed should take CharSequence #7

Open
westonal opened this issue Oct 9, 2017 · 0 comments
Open

calculateSeed should take CharSequence #7

westonal opened this issue Oct 9, 2017 · 0 comments

Comments

@westonal
Copy link
Member

westonal commented Oct 9, 2017 

 public byte[] calculateSeed(String mnemonic, String passphrase) {

This should be able to take CharSequence but the normalizer is insisting we have String input.
westonal pushed a commit that referenced this issue Oct 12, 2017
Allow test of checked exception to runtime, even if can’t throw in pl…
de71ff3 
…ace. Closes #7
westonal added a commit that referenced this issue Feb 2, 2018
@westonal
Allow creation of seeds from a list of words and allow validation of …
4d04cc6 
…word list - related to #7
westonal added a commit that referenced this issue Feb 2, 2018
@westonal
Allow creation of seeds from a list of words and allow validation of …
852470d 
…word list - related to #7 (#31)
westonal added a commit that referenced this issue Feb 3, 2018
@westonal
Remove the word not exactly in wordlist exception, with any word Char…
4ad0ddc 
…Sequence support for SeedCalculatorByWordListLookUp.

CharSequence support for Validation.
As long as formed of geuine words in any form (NFC, NFKD), it won’t create a new normalised String for them. #7
@westonal westonal mentioned this issue Feb 3, 2018
Merged
westonal added a commit that referenced this issue Feb 3, 2018
@westonal
Remove the word not exactly in wordlist exception, with any word Char…
b2ecd45 
…Sequence support for SeedCalculatorByWordListLookUp. (#33)

CharSequence support for Validation.
As long as formed of geuine words in any form (NFC, NFKD), it won’t create a new normalised String for them. #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@westonal