Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consider] Keep track of a source which contains a package #5184

Closed
mishra14 opened this issue May 8, 2017 · 3 comments
Closed

[Consider] Keep track of a source which contains a package #5184

mishra14 opened this issue May 8, 2017 · 3 comments
Labels
Functionality:Restore Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Tenet:Performance Performance issues Type:Feature
Milestone

Comments

@mishra14
Copy link
Contributor

mishra14 commented May 8, 2017

We should allow users to correlate a package with a source. This will prevent the initial discovery phase and the corresponding http calls to all the sources till the package is pulled down into the cache.

Possible solutions (In the order of preference)-

  1. Allow users to correlate a source with packages in NuGet.Config files.
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
  </packageSources>

  <packageDependencies>
    <nuget.org>
      <package id="PackageThatIsOnlyOnNuGet.Org"/>
    </nuget.org>
  </packageDependencies>
  
</configuration>

  1. Create a new restore graph file.
  2. Write the information into the NuGet.Cache file that will be added with restore no-op work.
  3. Write down this info into the assets file and make restore use that.
@nkolev92
Copy link
Member

nkolev92 commented Jul 3, 2020

Related to #6867

@MV10
Copy link

MV10 commented Jul 24, 2020

Ideally we could also indicate that it should only come from the source. Particularly during active development with a local source, caching just gets in the way. This is badly needed.

@nkolev92
Copy link
Member

Fixed by NuGet/NuGet.Client#3785.

Ideally we could also indicate that it should only come from the source. Particularly during active development with a local source, caching just gets in the way. This is badly needed.

Yep, definitely something on our radar. #6867 and #6579 are the 2 related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Tenet:Performance Performance issues Type:Feature
Projects
None yet
Development

No branches or pull requests

5 participants