Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"null" errors when deleting lines from NUA #479

Open
AviatingPenguin opened this issue Jul 23, 2023 · 3 comments
Open

"null" errors when deleting lines from NUA #479

AviatingPenguin opened this issue Jul 23, 2023 · 3 comments
Assignees
Labels

Comments

@AviatingPenguin
Copy link

AviatingPenguin commented Jul 23, 2023

Describe the Bug
if anyone tries to load a door game (not sure if will give errors at other times), enigma will throw null errors and crash (or load you in as a different person if there is already a person on the same door)

To Reproduce
Remove requirements for realname, birthday, etc (not username or password) from main.hjson and remove those fields from nua.ans (ex: remove @systemMethod:validateNonEmpty from "realname" in main.hjson)

Expected Behavior
doors and board to work normally

Actual Behavior
Users will be logged in as other users in door games, and errors will be thrown on the enigma instance causing crashes and at least one user complained of not being able to login via SSH (not sure if related or not)

Screenshots
nua

@NuSkooler
Copy link
Owner

There have been a few people that would like to collect less information in the NUA, but I suspect this is a problem for a few areas of the code that rely on some of those user properties.

I'll take a look and see what we can do!

@NuSkooler NuSkooler added the bug label Jul 24, 2023
@NuSkooler NuSkooler self-assigned this Jul 24, 2023
@NuSkooler
Copy link
Owner

@AviatingPenguin I've pushed a fix to the branch 479-nua-optional-field if you'd like to give it a try. Note that any users created before this fix with your changes will still have null, which this doesn't currently try to fully address -- you will need to re-create them, or update them via the user config screen (re-saving should not save the nulls)

@cognitivegears
Copy link
Collaborator

@AviatingPenguin Just wanted to check to see if you were able to retry this, or if you were running into any trouble? I see on your board that now you suggest people can put in bogus info instead - if you'd rather just leave as is that's totally good let me know and I'll just do whatever testing I can do from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants