Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in LAW 3 Level Inelastic Scatter #22

Open
HunterBelanger opened this issue Jun 1, 2021 · 0 comments
Open

Bug in LAW 3 Level Inelastic Scatter #22

HunterBelanger opened this issue Jun 1, 2021 · 0 comments

Comments

@HunterBelanger
Copy link

Currently, this documentation states that for level inelastic scattering, LDAT(1) = (1+A)*abs(Q)/A, implying that LDAT(1) should always be positive. This is typically true as Q values are generally negative, but this is not the case when looking at excited states, which may have positive Q values. One such example is Am244m1. Looking at line 10361 in acefc.f90, NJOY actually writes LDAT(1) = (1+A)*(-Q)/A. This is an important distinction for error checking in ACE files, as what NJOY actually writes can indeed be negative for excited states.

I have a fix prepared for this, but I am waiting to submit the PR, as there are several things that are waiting to be merged, and the PDF will is likely causing enough merge conflicts already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant