Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor statues are broken due to commented-out code #170

Open
haykam821 opened this issue Mar 12, 2024 · 0 comments
Open

Contributor statues are broken due to commented-out code #170

haykam821 opened this issue Mar 12, 2024 · 0 comments

Comments

@haykam821
Copy link
Contributor

Interacting with a contributor statue to open its UI does nothing, and placing a contributor statue with a contributor manually set does not place a player head onto the armor stand. As a result, the intended use of contributor statues is entirely broken.

There seems to be commented-out code related to this issue within the Contributor#loadGameProfileProperties method:

public void loadGameProfileProperties(MinecraftServer server, GameProfile profile, Consumer<GameProfile> callback) {
/*SkullBlockEntityAccessor.callFetchProfileWithTextures(profile).thenAccept(optional -> {
optional.ifPresent(fullProfile -> {
server.getUserCache().add(fullProfile);
callback.accept(fullProfile);
});
});*/
}

The referenced SkullBlockEntityAccessor class contains no accessors, and thus is unused:

@Mixin(SkullBlockEntity.class)
public class SkullBlockEntityAccessor {
}

This issue seems to have been introduced during the Minecraft 1.20.4 port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant