Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CARO IDs in cob-non-native OWL export #248

Open
4 tasks
cmungall opened this issue Jan 25, 2024 · 8 comments
Open
4 tasks

Replace CARO IDs in cob-non-native OWL export #248

cmungall opened this issue Jan 25, 2024 · 8 comments

Comments

@cmungall
Copy link
Contributor

cmungall commented Jan 25, 2024

Background

There are two COB products, one with native COB IDs, the other with OBO IDs rewired in.

Please do not use this issue to discuss whether other OBO IDs should be rewired in, or which of the two products should be primary. You are welcome to discuss this here:

The subject of this issue is what to do with the rewiring to CARO

Currently there are 3 IDs rewired to CARO:

image

Their mappings are here:

COB:0000021 gross anatomical part owl:equivalentClass CARO:0001008 gross anatomical part . semapv:ManualMappingCuration

COB:0000022 organism owl:equivalentClass CARO:0001010 organism or virus or viroid . semapv:ManualMappingCuration

COB:0000118 cellular organism owl:equivalentClass CARO:0010004 cellular organism . semapv:ManualMappingCuration

Recently developers of various anatomy ontologies decided to obsolete CARO in favor of Uberon. The Uberon class for e.g "tissue" would no longer mean "animal tissue", but simply "tissue". Ontologies like GO have swapped out CARO for Uberon, but this process is not complete for OBO as a whole.

For the full discussion, see:

This change has not been reflected in cob-to-external. For example, Uberon immaterial anatomical entity is a subclass of the COB class of the same name:

COB:0000056 immaterial anatomical entity sssom:superClassOf UBERON:0000466 immaterial anatomical entity . semapv:ManualMappingCuration

Leaving CARO in the rewired COB is problematic, since it is being phased out.

Replacements

These could potentially be broken into subtickets. I propose the following:

  1. CARO:0001008 ! gross anatomical part ==> add to uberon (NTRs: gross anatomical part, animal gross anatomical part obophenotype/uberon#2921) and use this
  2. CARO:0001010 ! organism ==> do NOT use NCBITaxon:1, see Propose changing the label on the NCBI top level term to 'NCBI root' obophenotype/ncbitaxon#10. Use COB:0000022
  3. CARO:0010004 ! cellular organism ==> NCBITaxon:131567 "cellular organisms"
  4. COB:0000056 ! immaterial anatomical entity ==> use Uberon (by switching predicate in mapping)

Note I am including 4 in this as well, it looks like the CARO mapping was accidentally omitted

I think 3 is a little unsatisfying due to the pluralization. However, this is consistent with the policy of using a native OBO ID in the rewired product

@ddooley
Copy link
Contributor

ddooley commented Jan 25, 2024

So COB:0000022 organism stands as the new ID for organism going forward? This is because it encompasses more than OBI Organism (i.e. viruses), and less than NCBITaxon (=not quite an ontology) root? UBERON doesn't want to mint an "organism" term because viruses don't fall within purview of UBERON's anatomy domain?!

@bpeters42
Copy link
Contributor

bpeters42 commented Jan 25, 2024 via email

@cmungall
Copy link
Contributor Author

Please let's keep the discussion focused on the issue at hand, @bpeters42 is right, this has nothing to do with viruses, these are included, this has already been decided, if you want to relitigate keep it on this issue, thanks!!

@ddooley
Copy link
Contributor

ddooley commented Jan 31, 2024

Ok, I misstepped there - not sure where I got notion that OBI organism didn't include viruses. But my point was that above @cmungall you said "Use COB:0000022". I was trying to figure out why you didn't say "use OBI:0100026"? If COB:0000022 maps to OBI:0100026 then I understand.

@cmungall
Copy link
Contributor Author

cmungall commented Feb 1, 2024 via email

@jamesaoverton
Copy link
Member

OBI does not want to own 'organism'. Maybe @ddooley is thinking about the perennial question of COB "adopting" the OBI:0100026 identifier vs using the new COB:0000022.

@ddooley
Copy link
Contributor

ddooley commented Feb 2, 2024

Yes! Am I to use COB:0000022 in FoodOn or ONS or whatever. Or use OBI:0100026? This ID that I'm specifying in my COB import file.

@cmungall
Copy link
Contributor Author

cmungall commented Feb 2, 2024

COB:0000022 is what you should use moving forward. Of course, it won't resolve until this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants