-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ontology Alzheimer's Disease Ontology #1806
Comments
Thank you, ontology links do not work! |
@matentzn Thank you for the feedback. It should be accessible now. |
@BideZ I am very happy you used all OBO ids, I hope you don't mind me sending you some feedback in your issue tracker: |
@BideZ thank you for your submission. thank you very much! Before we do our content review, we would like to invite you to make sure that your ontology passes the minimum QC threshold (or provide reasons why you don't want to / cannot): https://obofoundry.github.io/obo-nor.github.io/dashboard/index.html You can find the reports specific to ADO here:
Let us know when that is done (of if you don't want to do it), and we will commence with the review.
|
Two questions I have based on a cursory look through your metadata:
|
@matentzn Thank you for your feedback. We are currently trying to resolve some issues regarding the dangling terms(detailed explanation found in ADO issue 3). |
@matentzn Regarding the last comment:
|
@BideZ Thank you for your responses! We will assign a reviewer to ADO at the next OBO Foundry call, which should give you some time to address Fraunhofer-SCAI-Applied-Semantics/ADO#1 (this will have to be addressed before we start with the review). Note: None of what I told you here so far has anything to with the review - these are just gatekeeping checks to decide whether to review an ontology in the first place. The next OBO Foundry call is on the 22nd March, so you should hear from us at some point soon after that! |
@matentzn Thank you very much. We will leave a comment here as soon as the issues are resolved, or if there is any updates. Besides, the ADO you find in BioPortal was developed by our team. However, it was not constructed with OBO approved terms. We will discuss this with our team and see if we are changing the prefix, or we take this ADO as an update version. |
Yes thanks, that would be very important - it is against our principles to find one ADO here and another on BioPortal! |
@matentzn Here are some updates about the issues on ADO:
Thank you very much! |
@BideZ thank you for cleaning up, next step is for the OBO Foundry to assign a reviewer to your ontology. We will come back to you!
You can fill in this table: And make a pull request on RO! It will generate the related axioms automatically. Before you do, make a separate pull request here: https://github.com/oborel/obo-relations/blob/master/src/ontology/ro-idranges.owl and tag me in it! This is to give you and your team your own ID range, so you do not clash with others. |
@matentzn Thank you for the reply. I saw this line in the link you sent 'EquivalentTo: xsd:integer[...]' |
Yes, you just copy another persons range and give yourself a few ids in the equivalentTo statement. You change the range ID, add your name, and it's ok! I will fix anything should it be necessary :) |
@matentzn Thank you! We already created a pull request in this regard. The relations to be submitted include the ones from both ADO and Epilepsy Ontology (EPIO). Should we wait for the assignment of relation IDs or can we already start filling in the table you mentioned earlier? |
I merged the request. Note that you probably wont be able to add all relations at once; you first need to create issues like this one: And then make a pull request adding the information in the table. You have to add an ID from your ID range you just requested. It wont be a quick process - but it is a good one to go through. It is not pertinent to your request here, it just demonstrates that you are embracing the collaborative OBO spirit! |
I have posted issues at ADO found while reviewing the ontology. See Fraunhofer-SCAI-Applied-Semantics/ADO#6 |
summary: The ADO is intended to be used for tagging Alzheimer’s Disease literature for NLP. The ontology does not include new classes just imported ones that might be useful for their application. The value added appears to be ~10 object properties which have been submitted to RO. Problems were found in their imports (e.g., placed PATO colors under race) and in the object properties and reported as issues on their tracker. Because of this I can not recommend acceptance until the object property issues are better addressed. |
@cstoeckert Thank you for the feedback. After an internal discussion with our team and an overall evaluation, we have decided to remove 'isClassifiedSubclassOf' completely from ADO. One can get access to the latest version through https://github.com/Fraunhofer-SCAI-Applied-Semantics/ADO/blob/main/Releases/2.0.0/ADO.owl |
@cstoeckert does that decision address your concerns? |
@nlharris Removal of the 'isClassifiedSubclassOf' property addresses that issue and indicates a willingness to fix identified problems. There are additional problems but if @BideZ and team are willing to commit to addressing those too (e.g., misuse of 'is carrier of') then I could recommend acceptance. |
The last issue about 'is carrier of' has also been addressed. |
@BideZ @akodamullil Please note that this acceptance is based on the understanding that you will continue to address the issues raised including following up on the submission of properties to RO. I will also send this info to the email address of the contact person listed above. |
What are the next steps for this ontology? |
Nothing: its all done: https://obofoundry.org/ontology/ado.html |
@matentzn Dear Mr. Matentzoglu, Besides, ADO doesn't seem to show properly on OLS : https://www.ebi.ac.uk/ols/ontologies/ado. Do you have an idea why this has happened? Should I also report this as a new issue in Github? |
This is the wrong tracker for this.. Its also an old link, this is the new one: https://www.ebi.ac.uk/ols4/ontologies/ado These seem a few problems here, and I don't know how they came to be. Many ADO classes don have labels, like https://www.ebi.ac.uk/ols4/ontologies/ado/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FADO_0000032 This is where you configure the PURLs: https://github.com/OBOFoundry/purl.obolibrary.org/blob/master/config/ado.yml It is your responsibility but you can join OBO slack and ask for help there |
As Nico suggested, these issues have nothing to do with OBO Foundry. I hope you can find the right channels to get your issues fixed, BideZ! |
Ontology title
Alzheimer's Disease Ontology
Requested ID space
ADO
Ontology location
https://github.com/Fraunhofer-SCAI-Applied-Semantics/ADO/tree/main/Releases/2022-06-11/ADO.owl
Contact person
Name: Alpha Tom Kodamullil
Email address: [email protected]
GitHub username: akodamullil
Issue tracker
https://github.com/Fraunhofer-SCAI-Applied-Semantics/ADO/issues
Version Controlled Repository
https://github.com/Fraunhofer-SCAI-Applied-Semantics/ADO
Ontology license
Available ontology formats
.owl
What domain is the ontology intended to cover?
Alzheimer's Disease
Related OBO Foundry ontologies
SYMP, DOID, UBERON
Intended use/related projects
A disease ontology to classify Alzheimer's Disease and calculate semantic similarities in the domain of Alzheimer's Disease, Annotation of medical texts.
Data source
Several sources from domain experts assembled by Fraunhofer SCAI.
Additional comments or remarks
Created by the team for applied semantics at Fraunhofer SCAI
OBO Foundry pre-registration checklist
To be considered for inclusion in the OBO Foundry, an ontology must meet certain requirements, as described in in the registration process instructions and the registration review checklist. To ensure you are aware of some of its key points, please review the checklist below.
You can either check a box by submitted the request first and then using the GitHub interface, or replacing the
- [ ]
by- [X]
in the following.Metadata
Please fill in the following metadata record which will be used by the OBO Foundry website. Note that the values shown are just examples, for example
yourfourletterid
could be something likeaism
,cohm
,mondo
(it does not have to be four letters).your_domain_like_for_example_anatomy
could be simplyanatomy
, and the license should be whatever your actual license is. An example can be found here, but you really only need to fill in the metadata mentioned here.The text was updated successfully, but these errors were encountered: